gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX
authorBaruch Siach <baruch@tkos.co.il>
Wed, 20 Jan 2021 16:16:27 +0000 (18:16 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 15 Feb 2021 10:43:30 +0000 (11:43 +0100)
PWM on/off registers are limited to UINT_MAX. However the state period
and duty_cycle fields are ns values of type u64. There is no reason to
limit them to UINT_MAX.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-mvebu.c

index 8673ba7..6b01785 100644 (file)
@@ -669,9 +669,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip,
        regmap_read(mvpwm->regs, mvebu_pwmreg_blink_on_duration(mvpwm), &u);
        val = (unsigned long long) u * NSEC_PER_SEC;
        val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);
-       if (val > UINT_MAX)
-               state->duty_cycle = UINT_MAX;
-       else if (val)
+       if (val)
                state->duty_cycle = val;
        else
                state->duty_cycle = 1;
@@ -681,9 +679,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip,
        val += (unsigned long long) u; /* period = on + off duration */
        val *= NSEC_PER_SEC;
        val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);
-       if (val > UINT_MAX)
-               state->period = UINT_MAX;
-       else if (val)
+       if (val)
                state->period = val;
        else
                state->period = 1;