ASoC: wm_adsp: Remove pointless string comparison
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Sat, 26 Jun 2021 15:59:41 +0000 (16:59 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 11 Jul 2021 22:48:37 +0000 (23:48 +0100)
The control fw_name is always directly assigned from the wm_adsp_fw_text
array, so it isn't necessary to compare the actual strings just the
pointer values.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210626155941.12251-3-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 549d982..b395df1 100644 (file)
@@ -2030,10 +2030,9 @@ static struct wm_coeff_ctl *wm_adsp_get_ctl(struct wm_adsp *dsp,
                if (!pos->subname)
                        continue;
                if (strncmp(pos->subname, name, pos->subname_len) == 0 &&
-                   strncmp(pos->fw_name, fw_txt,
-                           SNDRV_CTL_ELEM_ID_NAME_MAXLEN) == 0 &&
-                               pos->alg_region.alg == alg &&
-                               pos->alg_region.type == type) {
+                   pos->fw_name == fw_txt &&
+                   pos->alg_region.alg == alg &&
+                   pos->alg_region.type == type) {
                        rslt = pos;
                        break;
                }