pinctrl: mcp23s08: Use full chunk of memory for regmap configuration
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 9 Oct 2020 18:08:55 +0000 (21:08 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 5 Nov 2020 10:30:17 +0000 (11:30 +0100)
It appears that simplification of mcp23s08_spi_regmap_init() made
a regression due to wrong size calculation for dev_kmemdup() call.
It misses the fact that config variable is already a pointer, thus
the sizeof() calculation is wrong and only 4 or 8 bytes were copied.

Fix the parameters to devm_kmemdup() to copy a full chunk of memory.

Fixes: 0874758ecb2b ("pinctrl: mcp23s08: Refactor mcp23s08_spi_regmap_init()")
Reported-by: Martin Hundebøll <martin@geanix.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Martin Hundebøll <martin@geanix.com>
Link: https://lore.kernel.org/r/20201009180856.4738-1-andriy.shevchenko@linux.intel.com
Tested-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08_spi.c

index 1f47a66..7c72cff 100644 (file)
@@ -119,7 +119,7 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev,
                return -EINVAL;
        }
 
-       copy = devm_kmemdup(dev, &config, sizeof(config), GFP_KERNEL);
+       copy = devm_kmemdup(dev, config, sizeof(*config), GFP_KERNEL);
        if (!copy)
                return -ENOMEM;