media: adv7180: Remove duplicate checks
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 31 Oct 2017 14:21:48 +0000 (10:21 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Dec 2017 15:12:45 +0000 (10:12 -0500)
Since i2c_unregister_device() became NULL-aware we may remove duplicate checks.

Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/adv7180.c

index 6fb818a..25d24a3 100644 (file)
@@ -1366,11 +1366,9 @@ err_media_entity_cleanup:
 err_free_ctrl:
        adv7180_exit_controls(state);
 err_unregister_vpp_client:
-       if (state->chip_info->flags & ADV7180_FLAG_I2P)
-               i2c_unregister_device(state->vpp_client);
+       i2c_unregister_device(state->vpp_client);
 err_unregister_csi_client:
-       if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2)
-               i2c_unregister_device(state->csi_client);
+       i2c_unregister_device(state->csi_client);
        mutex_destroy(&state->mutex);
        return ret;
 }
@@ -1388,10 +1386,8 @@ static int adv7180_remove(struct i2c_client *client)
        media_entity_cleanup(&sd->entity);
        adv7180_exit_controls(state);
 
-       if (state->chip_info->flags & ADV7180_FLAG_I2P)
-               i2c_unregister_device(state->vpp_client);
-       if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2)
-               i2c_unregister_device(state->csi_client);
+       i2c_unregister_device(state->vpp_client);
+       i2c_unregister_device(state->csi_client);
 
        adv7180_set_power_pin(state, false);