ALSA: pcm: Fix superfluous snprintf() usage
authorTakashi Iwai <tiwai@suse.de>
Fri, 13 Mar 2020 13:02:23 +0000 (14:02 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 13 Mar 2020 14:58:35 +0000 (15:58 +0100)
show_pcm_class() returns obviously a short string that can't overflow
PAGE_SIZE.  And even if it were to overflow, using snprintf() there is
just wrong, as it doesn't return the correct size.
So simplify with sprintf() instead.

Link: https://lore.kernel.org/r/20200313130223.8908-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm.c

index a141a30..b6d2331 100644 (file)
@@ -1019,7 +1019,7 @@ static ssize_t show_pcm_class(struct device *dev,
                str = "none";
        else
                str = strs[pcm->dev_class];
-        return snprintf(buf, PAGE_SIZE, "%s\n", str);
+       return sprintf(buf, "%s\n", str);
 }
 
 static DEVICE_ATTR(pcm_class, 0444, show_pcm_class, NULL);