ALSA: ppc: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:07:12 +0000 (12:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:35 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-91-tiwai@suse.de
sound/ppc/awacs.c
sound/ppc/burgundy.c
sound/ppc/daca.c
sound/ppc/pmac.c
sound/ppc/powermac.c
sound/ppc/snd_ps3.c

index 49399a4..13a6f3a 100644 (file)
@@ -956,7 +956,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
        /*
         * build mixers
         */
-       strcpy(chip->card->mixername, "PowerMac AWACS");
+       strscpy(chip->card->mixername, "PowerMac AWACS");
 
        err = build_mixers(chip, ARRAY_SIZE(snd_pmac_awacs_mixers),
                                snd_pmac_awacs_mixers);
index 400a886..ba15bc3 100644 (file)
@@ -665,7 +665,7 @@ int snd_pmac_burgundy_init(struct snd_pmac *chip)
        /*
         * build burgundy mixers
         */
-       strcpy(chip->card->mixername, "PowerMac Burgundy");
+       strscpy(chip->card->mixername, "PowerMac Burgundy");
 
        for (i = 0; i < ARRAY_SIZE(snd_pmac_burgundy_mixers); i++) {
                err = snd_ctl_add(chip->card,
index d576695..a741142 100644 (file)
@@ -261,7 +261,7 @@ int snd_pmac_daca_init(struct snd_pmac *chip)
        /*
         * build mixers
         */
-       strcpy(chip->card->mixername, "PowerMac DACA");
+       strscpy(chip->card->mixername, "PowerMac DACA");
 
        for (i = 0; i < ARRAY_SIZE(daca_mixers); i++) {
                err = snd_ctl_add(chip->card, snd_ctl_new1(&daca_mixers[i], chip));
index 76674c4..a3d346f 100644 (file)
@@ -679,7 +679,7 @@ int snd_pmac_pcm_new(struct snd_pmac *chip)
 
        pcm->private_data = chip;
        pcm->info_flags = SNDRV_PCM_INFO_JOINT_DUPLEX;
-       strcpy(pcm->name, chip->card->shortname);
+       strscpy(pcm->name, chip->card->shortname);
        chip->pcm = pcm;
 
        chip->formats_ok = SNDRV_PCM_FMTBIT_S16_BE;
index f1b0cf9..e685d24 100644 (file)
@@ -55,8 +55,8 @@ static int snd_pmac_probe(struct platform_device *devptr)
 
        switch (chip->model) {
        case PMAC_BURGUNDY:
-               strcpy(card->driver, "PMac Burgundy");
-               strcpy(card->shortname, "PowerMac Burgundy");
+               strscpy(card->driver, "PMac Burgundy");
+               strscpy(card->shortname, "PowerMac Burgundy");
                sprintf(card->longname, "%s (Dev %d) Sub-frame %d",
                        card->shortname, chip->device_id, chip->subframe);
                err = snd_pmac_burgundy_init(chip);
@@ -64,8 +64,8 @@ static int snd_pmac_probe(struct platform_device *devptr)
                        goto __error;
                break;
        case PMAC_DACA:
-               strcpy(card->driver, "PMac DACA");
-               strcpy(card->shortname, "PowerMac DACA");
+               strscpy(card->driver, "PMac DACA");
+               strscpy(card->shortname, "PowerMac DACA");
                sprintf(card->longname, "%s (Dev %d) Sub-frame %d",
                        card->shortname, chip->device_id, chip->subframe);
                err = snd_pmac_daca_init(chip);
index a6cff2c..ce7ee27 100644 (file)
@@ -951,9 +951,9 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
        if (ret < 0)
                goto clean_irq;
 
-       strcpy(the_card.card->driver, "PS3");
-       strcpy(the_card.card->shortname, "PS3");
-       strcpy(the_card.card->longname, "PS3 sound");
+       strscpy(the_card.card->driver, "PS3");
+       strscpy(the_card.card->shortname, "PS3");
+       strscpy(the_card.card->longname, "PS3 sound");
 
        /* create control elements */
        for (i = 0; i < ARRAY_SIZE(spdif_ctls); i++) {
@@ -975,7 +975,7 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
                goto clean_card;
 
        the_card.pcm->private_data = &the_card;
-       strcpy(the_card.pcm->name, "SPDIF");
+       strscpy(the_card.pcm->name, "SPDIF");
 
        /* set pcm ops */
        snd_pcm_set_ops(the_card.pcm, SNDRV_PCM_STREAM_PLAYBACK,