drm/ast: fix missing break in switch statement for format->cpp[0] case 4
authorColin Ian King <colin.king@canonical.com>
Wed, 10 Jun 2020 11:58:04 +0000 (12:58 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 11 Jun 2020 07:05:31 +0000 (09:05 +0200)
Currently the switch statement for format->cpp[0] value 4 assigns
color_index which is never read again and then falls through to the
default case and returns. This looks like a missing break statement
bug. Fix this by adding a break statement.

Addresses-Coverity: ("Unused value")
Fixes: 259d14a76a27 ("drm/ast: Split ast_set_vbios_mode_info()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200610115804.1132338-1-colin.king@canonical.com
drivers/gpu/drm/ast/ast_mode.c

index 7d39b85..3a3a511 100644 (file)
@@ -226,6 +226,7 @@ static void ast_set_vbios_color_reg(struct ast_private *ast,
        case 3:
        case 4:
                color_index = TrueCModeIndex;
+               break;
        default:
                return;
        }