pxa168fb: fix release function mismatch in probe failure
authorChuhong Yuan <hslester96@gmail.com>
Thu, 5 Dec 2019 16:06:13 +0000 (00:06 +0800)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Wed, 15 Jan 2020 16:31:45 +0000 (17:31 +0100)
The driver uses kfree() to release the resource allocated by
framebuffer_alloc(), which does not match.
Use framebuffer_release() instead to fix it.

Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191205160613.32075-1-hslester96@gmail.com
drivers/video/fbdev/pxa168fb.c

index 362d3df..3679698 100644 (file)
@@ -769,7 +769,7 @@ failed_free_fbmem:
        dma_free_wc(fbi->dev, info->fix.smem_len,
                    info->screen_base, fbi->fb_start_dma);
 failed_free_info:
-       kfree(info);
+       framebuffer_release(info);
 
        dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
        return ret;