wifi: rt2x00: Remove unused rfval values
authorAriel Otilibili <ariel.otilibili-anieli@eurecom.fr>
Sat, 21 Dec 2024 12:39:32 +0000 (13:39 +0100)
committerKalle Valo <kvalo@kernel.org>
Fri, 10 Jan 2025 13:11:06 +0000 (15:11 +0200)
The intention here is not clear but as this was already tested and matches
vendor driver it's better not to change behavior even if it looks suspicious.
So just remove the unused values.

Coverity-ID: 1525307

Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
[kvalo@kernel.org: write commit message]
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241221124445.1094460-2-ariel.otilibili-anieli@eurecom.fr
drivers/net/wireless/ralink/rt2x00/rt2800lib.c

index 60c2a12..e5f553a 100644 (file)
@@ -8882,13 +8882,10 @@ static void rt2800_rxiq_calibration(struct rt2x00_dev *rt2x00dev)
 
        for (ch_idx = 0; ch_idx < 2; ch_idx = ch_idx + 1) {
                if (ch_idx == 0) {
-                       rfval = rfb0r1 & (~0x3);
                        rfval = rfb0r1 | 0x1;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 1, rfval);
-                       rfval = rfb0r2 & (~0x33);
                        rfval = rfb0r2 | 0x11;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 2, rfval);
-                       rfval = rfb0r42 & (~0x50);
                        rfval = rfb0r42 | 0x10;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 42, rfval);
 
@@ -8901,13 +8898,10 @@ static void rt2800_rxiq_calibration(struct rt2x00_dev *rt2x00dev)
 
                        rt2800_bbp_dcoc_write(rt2x00dev, 1, 0x00);
                } else {
-                       rfval = rfb0r1 & (~0x3);
                        rfval = rfb0r1 | 0x2;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 1, rfval);
-                       rfval = rfb0r2 & (~0x33);
                        rfval = rfb0r2 | 0x22;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 2, rfval);
-                       rfval = rfb0r42 & (~0x50);
                        rfval = rfb0r42 | 0x40;
                        rt2800_rfcsr_write_bank(rt2x00dev, 0, 42, rfval);