staging: hv: Use kmemdup rather than duplicating its implementation

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 2c2e1b4..a28c549 100644 (file)
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -201,13 +201,11 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
        desc = &device_info->hid_descriptor;
        WARN_ON(desc->bLength == 0);
 
-       input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
+       input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
 
        if (!input_device->hid_desc)
                goto cleanup;
 
-       memcpy(input_device->hid_desc, desc, desc->bLength);
-
        input_device->report_desc_size = desc->desc[0].wDescriptorLength;
        if (input_device->report_desc_size == 0)
                goto cleanup;

diff --git a/drivers/staging/hv/netvsc.c b/drivers/staging/hv/netvsc.c
index b902579..28e69a6 100644 (file)
--- a/drivers/staging/hv/netvsc.c
+++ b/drivers/staging/hv/netvsc.c
@@ -230,19 +230,14 @@ static int netvsc_init_recv_buf(struct hv_device *device)
        net_device->recv_section_cnt = init_packet->msg.
                v1_msg.send_recv_buf_complete.num_sections;
 
-       net_device->recv_section = kmalloc(net_device->recv_section_cnt
-               * sizeof(struct nvsp_1_receive_buffer_section), GFP_KERNEL);
+       net_device->recv_section = kmemdup(init_packet->msg.v1_msg.send_recv_buf_complete.sections,
+                                          net_device->recv_section_cnt * sizeof(struct nvsp_1_receive_buffer_section),
+                                          GFP_KERNEL);
        if (net_device->recv_section == NULL) {
                ret = -EINVAL;
                goto cleanup;
        }
 
-       memcpy(net_device->recv_section,
-               init_packet->msg.v1_msg.
-              send_recv_buf_complete.sections,
-               net_device->recv_section_cnt *
-              sizeof(struct nvsp_1_receive_buffer_section));
-
        /*
         * For 1st release, there should only be 1 section that represents the
         * entire receive buffer