scsi: target: Remove TARGET_SCF_LOOKUP_LUN_FROM_TAG
authorMike Christie <michael.christie@oracle.com>
Sun, 1 Nov 2020 18:59:30 +0000 (12:59 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 5 Nov 2020 03:39:37 +0000 (22:39 -0500)
TARGET_SCF_LOOKUP_LUN_FROM_TAG is no longer used so remove it.

Link: https://lore.kernel.org/r/1604257174-4524-5-git-send-email-michael.christie@oracle.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_transport.c
include/target/target_core_base.h

index 46fc2ff..faf1bab 100644 (file)
@@ -1772,29 +1772,6 @@ static void target_complete_tmr_failure(struct work_struct *work)
        transport_cmd_check_stop_to_fabric(se_cmd);
 }
 
-static bool target_lookup_lun_from_tag(struct se_session *se_sess, u64 tag,
-                                      u64 *unpacked_lun)
-{
-       struct se_cmd *se_cmd;
-       unsigned long flags;
-       bool ret = false;
-
-       spin_lock_irqsave(&se_sess->sess_cmd_lock, flags);
-       list_for_each_entry(se_cmd, &se_sess->sess_cmd_list, se_cmd_list) {
-               if (se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)
-                       continue;
-
-               if (se_cmd->tag == tag) {
-                       *unpacked_lun = se_cmd->orig_fe_lun;
-                       ret = true;
-                       break;
-               }
-       }
-       spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);
-
-       return ret;
-}
-
 /**
  * target_submit_tmr - lookup unpacked lun and submit uninitialized se_cmd
  *                     for TMR CDBs
@@ -1842,16 +1819,6 @@ int target_submit_tmr(struct se_cmd *se_cmd, struct se_session *se_sess,
                core_tmr_release_req(se_cmd->se_tmr_req);
                return ret;
        }
-       /*
-        * If this is ABORT_TASK with no explicit fabric provided LUN,
-        * go ahead and search active session tags for a match to figure
-        * out unpacked_lun for the original se_cmd.
-        */
-       if (tm_type == TMR_ABORT_TASK && (flags & TARGET_SCF_LOOKUP_LUN_FROM_TAG)) {
-               if (!target_lookup_lun_from_tag(se_sess, tag,
-                                               &se_cmd->orig_fe_lun))
-                       goto failure;
-       }
 
        ret = transport_lookup_tmr_lun(se_cmd);
        if (ret)
index 7ee2bee..7d63259 100644 (file)
@@ -195,7 +195,6 @@ enum target_sc_flags_table {
        TARGET_SCF_ACK_KREF             = 0x02,
        TARGET_SCF_UNKNOWN_SIZE         = 0x04,
        TARGET_SCF_USE_CPUID            = 0x08,
-       TARGET_SCF_LOOKUP_LUN_FROM_TAG  = 0x10,
 };
 
 /* fabric independent task management function values */