powerpc/eeh: Delete eeh_pe->config_addr
authorOliver O'Halloran <oohall@gmail.com>
Wed, 7 Oct 2020 04:09:02 +0000 (15:09 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 7 Oct 2020 11:34:47 +0000 (22:34 +1100)
The eeh_pe->config_addr field was supposed to be removed in
commit 35d64734b643 ("powerpc/eeh: Clean up PE addressing") which made it
largely unused. Finish the job.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201007040903.819081-1-oohall@gmail.com
arch/powerpc/include/asm/eeh.h
arch/powerpc/kernel/eeh.c
arch/powerpc/kernel/eeh_pe.c

index dd6a4ac..b1a5bba 100644 (file)
@@ -73,7 +73,6 @@ struct pci_dn;
 struct eeh_pe {
        int type;                       /* PE type: PHB/Bus/Device      */
        int state;                      /* PE EEH dependent mode        */
-       int config_addr;                /* Traditional PCI address      */
        int addr;                       /* PE configuration address     */
        struct pci_controller *phb;     /* Associated PHB               */
        struct pci_bus *bus;            /* Top PCI bus for bus PE       */
index 87de8b7..0e160df 100644 (file)
@@ -466,7 +466,7 @@ int eeh_dev_check_failure(struct eeh_dev *edev)
                return 0;
        }
 
-       if (!pe->addr && !pe->config_addr) {
+       if (!pe->addr) {
                eeh_stats.no_cfg_addr++;
                return 0;
        }
index 61b7d40..845e024 100644 (file)
@@ -354,8 +354,8 @@ int eeh_pe_tree_insert(struct eeh_dev *edev, struct eeh_pe *new_pe_parent)
                pr_err("%s: out of memory!\n", __func__);
                return -ENOMEM;
        }
-       pe->addr        = edev->pe_config_addr;
-       pe->config_addr = edev->bdfn;
+
+       pe->addr = edev->pe_config_addr;
 
        /*
         * Put the new EEH PE into hierarchy tree. If the parent