drm/i915: move ppgtt_type and ppgtt_size to runtime info
authorJani Nikula <jani.nikula@intel.com>
Fri, 19 Aug 2022 12:02:40 +0000 (15:02 +0300)
committerJani Nikula <jani.nikula@intel.com>
Wed, 24 Aug 2022 08:45:26 +0000 (11:45 +0300)
If it's modified runtime, it's runtime info.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Maarten Lankhort <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/9a9b94cb79a00229da5a564a16ea750a6d392ab6.1660910433.git.jani.nikula@intel.com
drivers/gpu/drm/i915/gem/selftests/huge_pages.c
drivers/gpu/drm/i915/gt/intel_ppgtt.c
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_pci.c
drivers/gpu/drm/i915/intel_device_info.c
drivers/gpu/drm/i915/intel_device_info.h

index 8fcffd1..c570cf7 100644 (file)
@@ -1764,8 +1764,8 @@ int i915_gem_huge_page_mock_selftests(void)
                return -ENOMEM;
 
        /* Pretend to be a device which supports the 48b PPGTT */
-       mkwrite_device_info(dev_priv)->ppgtt_type = INTEL_PPGTT_FULL;
-       mkwrite_device_info(dev_priv)->ppgtt_size = 48;
+       RUNTIME_INFO(dev_priv)->ppgtt_type = INTEL_PPGTT_FULL;
+       RUNTIME_INFO(dev_priv)->ppgtt_size = 48;
 
        ppgtt = i915_ppgtt_create(to_gt(dev_priv), 0);
        if (IS_ERR(ppgtt)) {
index d8b94d6..bf8570a 100644 (file)
@@ -308,7 +308,7 @@ void ppgtt_init(struct i915_ppgtt *ppgtt, struct intel_gt *gt,
        ppgtt->vm.gt = gt;
        ppgtt->vm.i915 = i915;
        ppgtt->vm.dma = i915->drm.dev;
-       ppgtt->vm.total = BIT_ULL(INTEL_INFO(i915)->ppgtt_size);
+       ppgtt->vm.total = BIT_ULL(RUNTIME_INFO(i915)->ppgtt_size);
        ppgtt->vm.lmem_pt_obj_flags = lmem_pt_obj_flags;
 
        dma_resv_init(&ppgtt->vm._resv);
index 7ac36e7..40c4195 100644 (file)
@@ -1210,7 +1210,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 
 #define HAS_EXECLISTS(dev_priv) HAS_LOGICAL_RING_CONTEXTS(dev_priv)
 
-#define INTEL_PPGTT(dev_priv) (INTEL_INFO(dev_priv)->ppgtt_type)
+#define INTEL_PPGTT(dev_priv) (RUNTIME_INFO(dev_priv)->ppgtt_type)
 #define HAS_PPGTT(dev_priv) \
        (INTEL_PPGTT(dev_priv) != INTEL_PPGTT_NONE)
 #define HAS_FULL_PPGTT(dev_priv) \
index e34a64a..af34a38 100644 (file)
@@ -421,8 +421,8 @@ static const struct intel_device_info ilk_m_info = {
        .has_rc6p = 1, \
        .has_rps = true, \
        .dma_mask_size = 40, \
-       .ppgtt_type = INTEL_PPGTT_ALIASING, \
-       .ppgtt_size = 31, \
+       .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \
+       .__runtime.ppgtt_size = 31, \
        I9XX_PIPE_OFFSETS, \
        I9XX_CURSOR_OFFSETS, \
        ILK_COLORS, \
@@ -474,8 +474,8 @@ static const struct intel_device_info snb_m_gt2_info = {
        .has_reset_engine = true, \
        .has_rps = true, \
        .dma_mask_size = 40, \
-       .ppgtt_type = INTEL_PPGTT_ALIASING, \
-       .ppgtt_size = 31, \
+       .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \
+       .__runtime.ppgtt_size = 31, \
        IVB_PIPE_OFFSETS, \
        IVB_CURSOR_OFFSETS, \
        IVB_COLORS, \
@@ -535,8 +535,8 @@ static const struct intel_device_info vlv_info = {
        .display.has_gmch = 1,
        .display.has_hotplug = 1,
        .dma_mask_size = 40,
-       .ppgtt_type = INTEL_PPGTT_ALIASING,
-       .ppgtt_size = 31,
+       .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING,
+       .__runtime.ppgtt_size = 31,
        .has_snoop = true,
        .has_coherent_ggtt = false,
        .platform_engine_mask = BIT(RCS0) | BIT(VCS0) | BIT(BCS0),
@@ -585,8 +585,8 @@ static const struct intel_device_info hsw_gt3_info = {
        GEN(8), \
        .has_logical_ring_contexts = 1, \
        .dma_mask_size = 39, \
-       .ppgtt_type = INTEL_PPGTT_FULL, \
-       .ppgtt_size = 48, \
+       .__runtime.ppgtt_type = INTEL_PPGTT_FULL, \
+       .__runtime.ppgtt_size = 48, \
        .has_64bit_reloc = 1
 
 #define BDW_PLATFORM \
@@ -633,8 +633,8 @@ static const struct intel_device_info chv_info = {
        .has_logical_ring_contexts = 1,
        .display.has_gmch = 1,
        .dma_mask_size = 39,
-       .ppgtt_type = INTEL_PPGTT_FULL,
-       .ppgtt_size = 32,
+       .__runtime.ppgtt_type = INTEL_PPGTT_FULL,
+       .__runtime.ppgtt_size = 32,
        .has_reset_engine = 1,
        .has_snoop = true,
        .has_coherent_ggtt = false,
@@ -719,8 +719,8 @@ static const struct intel_device_info skl_gt4_info = {
        .has_logical_ring_contexts = 1, \
        .has_gt_uc = 1, \
        .dma_mask_size = 39, \
-       .ppgtt_type = INTEL_PPGTT_FULL, \
-       .ppgtt_size = 48, \
+       .__runtime.ppgtt_type = INTEL_PPGTT_FULL, \
+       .__runtime.ppgtt_size = 48, \
        .has_reset_engine = 1, \
        .has_snoop = true, \
        .has_coherent_ggtt = false, \
@@ -848,14 +848,14 @@ static const struct intel_device_info ehl_info = {
        GEN11_FEATURES,
        PLATFORM(INTEL_ELKHARTLAKE),
        .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
-       .ppgtt_size = 36,
+       .__runtime.ppgtt_size = 36,
 };
 
 static const struct intel_device_info jsl_info = {
        GEN11_FEATURES,
        PLATFORM(INTEL_JASPERLAKE),
        .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
-       .ppgtt_size = 36,
+       .__runtime.ppgtt_size = 36,
 };
 
 #define GEN12_FEATURES \
@@ -927,7 +927,7 @@ static const struct intel_device_info dg1_info = {
                BIT(RCS0) | BIT(BCS0) | BIT(VECS0) |
                BIT(VCS0) | BIT(VCS2),
        /* Wa_16011227922 */
-       .ppgtt_size = 47,
+       .__runtime.ppgtt_size = 47,
 };
 
 static const struct intel_device_info adl_s_info = {
@@ -994,7 +994,7 @@ static const struct intel_device_info adl_p_info = {
        .display.has_psr_hw_tracking = 0,
        .platform_engine_mask =
                BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
-       .ppgtt_size = 48,
+       .__runtime.ppgtt_size = 48,
        .dma_mask_size = 39,
 };
 
@@ -1023,8 +1023,8 @@ static const struct intel_device_info adl_p_info = {
        .has_reset_engine = 1, \
        .has_rps = 1, \
        .has_runtime_pm = 1, \
-       .ppgtt_size = 48, \
-       .ppgtt_type = INTEL_PPGTT_FULL
+       .__runtime.ppgtt_size = 48, \
+       .__runtime.ppgtt_type = INTEL_PPGTT_FULL
 
 #define XE_HPM_FEATURES \
        .media.ver = 12, \
index ec9c8e9..0efbd8f 100644 (file)
@@ -112,8 +112,8 @@ void intel_device_info_print(const struct intel_device_info *info,
        drm_printf(p, "memory-regions: %x\n", info->memory_regions);
        drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);
        drm_printf(p, "platform: %s\n", intel_platform_name(info->platform));
-       drm_printf(p, "ppgtt-size: %d\n", info->ppgtt_size);
-       drm_printf(p, "ppgtt-type: %d\n", info->ppgtt_type);
+       drm_printf(p, "ppgtt-size: %d\n", runtime->ppgtt_size);
+       drm_printf(p, "ppgtt-type: %d\n", runtime->ppgtt_type);
        drm_printf(p, "dma_mask_size: %u\n", info->dma_mask_size);
 
 #define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->name))
@@ -409,7 +409,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
        if (GRAPHICS_VER(dev_priv) == 6 && i915_vtd_active(dev_priv)) {
                drm_info(&dev_priv->drm,
                         "Disabling ppGTT for VT-d support\n");
-               info->ppgtt_type = INTEL_PPGTT_NONE;
+               runtime->ppgtt_type = INTEL_PPGTT_NONE;
        }
 
        runtime->rawclk_freq = intel_read_rawclk(dev_priv);
index 97e45bb..c49d167 100644 (file)
@@ -223,6 +223,9 @@ struct intel_runtime_info {
 
        unsigned int page_sizes; /* page sizes supported by the HW */
 
+       enum intel_ppgtt_type ppgtt_type;
+       unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
+
        /* display */
        struct {
                u8 num_sprites[I915_MAX_PIPES];
@@ -241,9 +244,6 @@ struct intel_device_info {
 
        unsigned int dma_mask_size; /* available DMA address bits */
 
-       enum intel_ppgtt_type ppgtt_type;
-       unsigned int ppgtt_size; /* log2, e.g. 31/32/48 bits */
-
        u32 memory_regions; /* regions supported by the HW */
 
        u8 gt; /* GT number, 0 if undefined */