drm/i915/vdsc: Add function to write in PPS register

Now that we have a function that reads any PPS register based
on intel_dsc_pps enum provided lets create a function that can
write on any PPS.

--v2
-Changes need as PPS enum was dropped
-Remove duplicated code in intel_dsc_write_pps_reg [Jani]

--v3
-Use dsc_split instead of num_vdsc_instances [Ankit]

--v5
-Changes to implement the new dsc_reg array variable passing
[Ankit]

--v7
-Pass no of vdsc instances to get_pps_reg [Ankit]

--v8
-No need for dsc_reg dynamic allocation [Jani]
-Change function to void as no return needs to be sent back

--v9
-Send ARRAY_SIZE(dsc_reg) instead of vdsc_per_pipe [Ankit]

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230828054300.560559-6-suraj.kandpal@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index f90424e..7dfc874 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -393,6 +393,22 @@ static void intel_dsc_get_pps_reg(const struct intel_crtc_state *crtc_state, int
        }
 }
 
+static void intel_dsc_write_pps_reg(const struct intel_crtc_state *crtc_state,
+                                   int pps, u32 pps_val)
+{
+       struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+       struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+       i915_reg_t dsc_reg[2];
+       int i, vdsc_per_pipe = intel_dsc_get_vdsc_per_pipe(crtc_state);
+
+       drm_WARN_ON_ONCE(&i915->drm, ARRAY_SIZE(dsc_reg) < vdsc_per_pipe);
+
+       intel_dsc_get_pps_reg(crtc_state, pps, dsc_reg, vdsc_per_pipe);
+
+       for (i = 0; i < min_t(int, ARRAY_SIZE(dsc_reg), vdsc_per_pipe); i++)
+               intel_de_write(i915, dsc_reg[i], pps_val);
+}
+
 static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
 {
        struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
@@ -428,149 +444,41 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
        if (vdsc_cfg->vbr_enable)
                pps_val |= DSC_VBR_ENABLE;
        drm_dbg_kms(&dev_priv->drm, "PPS0 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_0,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_0,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_0(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_0(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 0, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_1 registers */
        pps_val = 0;
        pps_val |= DSC_BPP(vdsc_cfg->bits_per_pixel);
        drm_dbg_kms(&dev_priv->drm, "PPS1 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_1,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_1,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_1(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_1(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 1, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_2 registers */
        pps_val = 0;
        pps_val |= DSC_PIC_HEIGHT(vdsc_cfg->pic_height) |
                DSC_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances);
        drm_dbg_kms(&dev_priv->drm, "PPS2 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_2,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_2,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_2(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_2(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 2, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_3 registers */
        pps_val = 0;
        pps_val |= DSC_SLICE_HEIGHT(vdsc_cfg->slice_height) |
                DSC_SLICE_WIDTH(vdsc_cfg->slice_width);
        drm_dbg_kms(&dev_priv->drm, "PPS3 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_3,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_3,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_3(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_3(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 3, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_4 registers */
        pps_val = 0;
        pps_val |= DSC_INITIAL_XMIT_DELAY(vdsc_cfg->initial_xmit_delay) |
                DSC_INITIAL_DEC_DELAY(vdsc_cfg->initial_dec_delay);
        drm_dbg_kms(&dev_priv->drm, "PPS4 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_4,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_4,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_4(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_4(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 4, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_5 registers */
        pps_val = 0;
        pps_val |= DSC_SCALE_INC_INT(vdsc_cfg->scale_increment_interval) |
                DSC_SCALE_DEC_INT(vdsc_cfg->scale_decrement_interval);
        drm_dbg_kms(&dev_priv->drm, "PPS5 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_5,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_5,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_5(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_5(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 5, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_6 registers */
        pps_val = 0;
@@ -579,100 +487,28 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
                DSC_FLATNESS_MIN_QP(vdsc_cfg->flatness_min_qp) |
                DSC_FLATNESS_MAX_QP(vdsc_cfg->flatness_max_qp);
        drm_dbg_kms(&dev_priv->drm, "PPS6 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_6,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_6,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_6(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_6(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 6, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_7 registers */
        pps_val = 0;
        pps_val |= DSC_SLICE_BPG_OFFSET(vdsc_cfg->slice_bpg_offset) |
                DSC_NFL_BPG_OFFSET(vdsc_cfg->nfl_bpg_offset);
        drm_dbg_kms(&dev_priv->drm, "PPS7 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_7,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_7,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_7(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_7(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 7, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_8 registers */
        pps_val = 0;
        pps_val |= DSC_FINAL_OFFSET(vdsc_cfg->final_offset) |
                DSC_INITIAL_OFFSET(vdsc_cfg->initial_offset);
        drm_dbg_kms(&dev_priv->drm, "PPS8 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_8,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_8,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_8(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_8(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 8, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_9 registers */
        pps_val = 0;
        pps_val |= DSC_RC_MODEL_SIZE(vdsc_cfg->rc_model_size) |
                DSC_RC_EDGE_FACTOR(DSC_RC_EDGE_FACTOR_CONST);
        drm_dbg_kms(&dev_priv->drm, "PPS9 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_9,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv, DSCC_PICTURE_PARAMETER_SET_9,
-                                      pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_9(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_9(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 9, pps_val);
 
        /* Populate PICTURE_PARAMETER_SET_10 registers */
        pps_val = 0;
@@ -681,25 +517,7 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
                DSC_RC_TARGET_OFF_HIGH(DSC_RC_TGT_OFFSET_HI_CONST) |
                DSC_RC_TARGET_OFF_LOW(DSC_RC_TGT_OFFSET_LO_CONST);
        drm_dbg_kms(&dev_priv->drm, "PPS10 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_10,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      DSCC_PICTURE_PARAMETER_SET_10, pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_10(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_10(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 10, pps_val);
 
        /* Populate Picture parameter set 16 */
        pps_val = 0;
@@ -709,51 +527,21 @@ static void intel_dsc_pps_configure(const struct intel_crtc_state *crtc_state)
                DSC_SLICE_ROW_PER_FRAME(vdsc_cfg->pic_height /
                                        vdsc_cfg->slice_height);
        drm_dbg_kms(&dev_priv->drm, "PPS16 = 0x%08x\n", pps_val);
-       if (!is_pipe_dsc(crtc, cpu_transcoder)) {
-               intel_de_write(dev_priv, DSCA_PICTURE_PARAMETER_SET_16,
-                              pps_val);
-               /*
-                * If 2 VDSC instances are needed, configure PPS for second
-                * VDSC
-                */
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      DSCC_PICTURE_PARAMETER_SET_16, pps_val);
-       } else {
-               intel_de_write(dev_priv,
-                              ICL_DSC0_PICTURE_PARAMETER_SET_16(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      ICL_DSC1_PICTURE_PARAMETER_SET_16(pipe),
-                                      pps_val);
-       }
+       intel_dsc_write_pps_reg(crtc_state, 16, pps_val);
 
        if (DISPLAY_VER(dev_priv) >= 14) {
                /* Populate PICTURE_PARAMETER_SET_17 registers */
                pps_val = 0;
                pps_val |= DSC_SL_BPG_OFFSET(vdsc_cfg->second_line_bpg_offset);
                drm_dbg_kms(&dev_priv->drm, "PPS17 = 0x%08x\n", pps_val);
-               intel_de_write(dev_priv,
-                              MTL_DSC0_PICTURE_PARAMETER_SET_17(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      MTL_DSC1_PICTURE_PARAMETER_SET_17(pipe),
-                                      pps_val);
+               intel_dsc_write_pps_reg(crtc_state, 17, pps_val);
 
                /* Populate PICTURE_PARAMETER_SET_18 registers */
                pps_val = 0;
                pps_val |= DSC_NSL_BPG_OFFSET(vdsc_cfg->nsl_bpg_offset) |
                           DSC_SL_OFFSET_ADJ(vdsc_cfg->second_line_offset_adj);
                drm_dbg_kms(&dev_priv->drm, "PPS18 = 0x%08x\n", pps_val);
-               intel_de_write(dev_priv,
-                              MTL_DSC0_PICTURE_PARAMETER_SET_18(pipe),
-                              pps_val);
-               if (vdsc_instances_per_pipe > 1)
-                       intel_de_write(dev_priv,
-                                      MTL_DSC1_PICTURE_PARAMETER_SET_18(pipe),
-                                      pps_val);
+               intel_dsc_write_pps_reg(crtc_state, 18, pps_val);
        }
 
        /* Populate the RC_BUF_THRESH registers */