mm: remove watermark_boost_factor_sysctl_handler
authorChristoph Hellwig <hch@lst.de>
Fri, 24 Apr 2020 06:43:35 +0000 (08:43 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 27 Apr 2020 06:06:52 +0000 (02:06 -0400)
watermark_boost_factor_sysctl_handler is just a pointless wrapper for
proc_dointvec_minmax, so remove it and use proc_dointvec_minmax
directly.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
include/linux/mmzone.h
kernel/sysctl.c
mm/page_alloc.c

index 1b9de7d..f37bb8f 100644 (file)
@@ -911,8 +911,6 @@ static inline int is_highmem(struct zone *zone)
 struct ctl_table;
 int min_free_kbytes_sysctl_handler(struct ctl_table *, int,
                                        void __user *, size_t *, loff_t *);
-int watermark_boost_factor_sysctl_handler(struct ctl_table *, int,
-                                       void __user *, size_t *, loff_t *);
 int watermark_scale_factor_sysctl_handler(struct ctl_table *, int,
                                        void __user *, size_t *, loff_t *);
 extern int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES];
index 8a176d8..99d27ac 100644 (file)
@@ -1491,7 +1491,7 @@ static struct ctl_table vm_table[] = {
                .data           = &watermark_boost_factor,
                .maxlen         = sizeof(watermark_boost_factor),
                .mode           = 0644,
-               .proc_handler   = watermark_boost_factor_sysctl_handler,
+               .proc_handler   = proc_dointvec_minmax,
                .extra1         = SYSCTL_ZERO,
        },
        {
index 69827d4..62c1550 100644 (file)
@@ -7978,18 +7978,6 @@ int min_free_kbytes_sysctl_handler(struct ctl_table *table, int write,
        return 0;
 }
 
-int watermark_boost_factor_sysctl_handler(struct ctl_table *table, int write,
-       void __user *buffer, size_t *length, loff_t *ppos)
-{
-       int rc;
-
-       rc = proc_dointvec_minmax(table, write, buffer, length, ppos);
-       if (rc)
-               return rc;
-
-       return 0;
-}
-
 int watermark_scale_factor_sysctl_handler(struct ctl_table *table, int write,
        void __user *buffer, size_t *length, loff_t *ppos)
 {