block: print symbolic error name instead of error code
authorChristian Heusel <christian@heusel.eu>
Thu, 11 Jan 2024 23:15:18 +0000 (00:15 +0100)
committerJens Axboe <axboe@kernel.dk>
Fri, 12 Jan 2024 16:07:46 +0000 (09:07 -0700)
Utilize the %pe print specifier to get the symbolic error name as a
string (i.e "-ENOMEM") in the log message instead of the error code to
increase its readablility.

This change was suggested in
https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/

Signed-off-by: Christian Heusel <christian@heusel.eu>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20240111231521.1596838-1-christian@heusel.eu
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c

index e6ac736..cab0d76 100644 (file)
@@ -562,8 +562,8 @@ static bool blk_add_partition(struct gendisk *disk,
        part = add_partition(disk, p, from, size, state->parts[p].flags,
                             &state->parts[p].info);
        if (IS_ERR(part) && PTR_ERR(part) != -ENXIO) {
-               printk(KERN_ERR " %s: p%d could not be added: %ld\n",
-                      disk->disk_name, p, -PTR_ERR(part));
+               printk(KERN_ERR " %s: p%d could not be added: %pe\n",
+                      disk->disk_name, p, part);
                return true;
        }