greybus: arche-platform: Avoid doing same thing again in poweroff fn
authorVaibhav Hiremath <vaibhav.hiremath@linaro.org>
Mon, 22 Feb 2016 11:57:25 +0000 (17:27 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Wed, 24 Feb 2016 06:43:06 +0000 (22:43 -0800)
If user switches from fw_flashing => off mode, then we do not need
to do same things again, for example, clk_disable and wake/detect event,
as while switching to fw_flashing, driver makes sure that device goes
to off state and then brings back in fw_flashing state.

Testing Done: Tested on DB3.5 platform.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/arche-platform.c

index 2dc11fd..efeafb3 100644 (file)
@@ -185,11 +185,15 @@ static void arche_platform_poweroff_seq(struct arche_platform_drvdata *arche_pda
        if (arche_pdata->state == ARCHE_PLATFORM_STATE_OFF)
                return;
 
-       /* Send disconnect/detach event to SVC */
-       gpio_set_value(arche_pdata->wake_detect_gpio, 0);
-       usleep_range(100, 200);
+       /* If in fw_flashing mode, then no need to repeate things again */
+       if (arche_pdata->state != ARCHE_PLATFORM_STATE_FW_FLASHING) {
+               /* Send disconnect/detach event to SVC */
+               gpio_set_value(arche_pdata->wake_detect_gpio, 0);
+               usleep_range(100, 200);
+
+               clk_disable_unprepare(arche_pdata->svc_ref_clk);
+       }
 
-       clk_disable_unprepare(arche_pdata->svc_ref_clk);
        /* As part of exit, put APB back in reset state */
        svc_reset_onoff(arche_pdata->svc_reset_gpio,
                        arche_pdata->is_reset_act_hi);