ASoC: Intel: Skylake: skl-topology: remove redundant assignments
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 20:01:45 +0000 (15:01 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Aug 2020 10:50:24 +0000 (11:50 +0100)
Cppcheck complains about possible NULL pointer dereferences but the
assignments are actually not needed before walking through lists.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813200147.61990-20-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-topology.c

index b7d2d97..3928a16 100644 (file)
@@ -550,8 +550,8 @@ static int skl_tplg_unload_pipe_modules(struct skl_dev *skl,
         struct skl_pipe *pipe)
 {
        int ret = 0;
-       struct skl_pipe_module *w_module = NULL;
-       struct skl_module_cfg *mconfig = NULL;
+       struct skl_pipe_module *w_module;
+       struct skl_module_cfg *mconfig;
 
        list_for_each_entry(w_module, &pipe->w_list, node) {
                guid_t *uuid_mod;
@@ -1893,7 +1893,7 @@ static int skl_tplg_be_set_src_pipe_params(struct snd_soc_dai *dai,
 static int skl_tplg_be_set_sink_pipe_params(struct snd_soc_dai *dai,
        struct snd_soc_dapm_widget *w, struct skl_pipe_params *params)
 {
-       struct snd_soc_dapm_path *p = NULL;
+       struct snd_soc_dapm_path *p;
        int ret = -EIO;
 
        snd_soc_dapm_widget_for_each_sink_path(w, p) {