USB: typec: fusb302: create debugfs subdir for the driver
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Feb 2021 14:46:44 +0000 (15:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:37:15 +0000 (09:37 +0100)
The single debugfs file for this driver really is a log file, so make a
subdir and call it "log" to make it obvious this is what it is for.
This makes cleanup simpler as we just remove the whole directory, no
need to handle individual files anymore.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210216144645.3813043-5-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/fusb302.c

index ebc46b9..7a2a178 100644 (file)
@@ -213,8 +213,9 @@ static void fusb302_debugfs_init(struct fusb302_chip *chip)
 
        mutex_init(&chip->logbuffer_lock);
        snprintf(name, NAME_MAX, "fusb302-%s", dev_name(chip->dev));
-       chip->dentry = debugfs_create_file(name, S_IFREG | 0444, usb_debug_root,
-                                          chip, &fusb302_debug_fops);
+       chip->dentry = debugfs_create_dir(name, usb_debug_root);
+       debugfs_create_file("log", S_IFREG | 0444, chip->dentry, chip,
+                           &fusb302_debug_fops);
 }
 
 static void fusb302_debugfs_exit(struct fusb302_chip *chip)