mlxsw: spectrum_router: Adjust comments on nexthop fields
authorIdo Schimmel <idosch@nvidia.com>
Mon, 22 Mar 2021 15:58:45 +0000 (17:58 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Mar 2021 20:45:46 +0000 (13:45 -0700)
The comments assume that nexthops are simple Ethernet nexthops
that are programmed to forward packets to the associated neighbour. This
is no longer the case, as both IPinIP and blackhole nexthops are now
supported.

Adjust the comments to reflect these changes.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

index b7358cf..bdf519b 100644 (file)
@@ -2862,14 +2862,14 @@ struct mlxsw_sp_nexthop {
        int norm_nh_weight;
        int num_adj_entries;
        struct mlxsw_sp_rif *rif;
-       u8 should_offload:1, /* set indicates this neigh is connected and
-                             * should be put to KVD linear area of this group.
+       u8 should_offload:1, /* set indicates this nexthop should be written
+                             * to the adjacency table.
                              */
-          offloaded:1, /* set in case the neigh is actually put into
-                        * KVD linear area of this group.
+          offloaded:1, /* set indicates this nexthop was written to the
+                        * adjacency table.
                         */
-          update:1, /* set indicates that MAC of this neigh should be
-                     * updated in HW
+          update:1, /* set indicates this nexthop should be updated in the
+                     * adjacency table (f.e., its MAC changed).
                      */
           discard:1; /* nexthop is programmed to discard packets */
        enum mlxsw_sp_nexthop_type type;