igbvf: Refactor traces
authorKaren Sornek <karen.sornek@intel.com>
Thu, 10 Sep 2020 10:36:19 +0000 (12:36 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 24 Nov 2020 16:02:24 +0000 (08:02 -0800)
Refactoring "PF still resetting" and changing "Failed
 to add vlan id" to "Vlan id is not added"
messages because previous version looked like a bug
- it informed about changes that worked as
designed but might confuse users

Signed-off-by: Karen Sornek <karen.sornek@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igbvf/netdev.c

index ee9f8c1..30fdea2 100644 (file)
@@ -1236,7 +1236,7 @@ static int igbvf_vlan_rx_add_vid(struct net_device *netdev,
        spin_lock_bh(&hw->mbx_lock);
 
        if (hw->mac.ops.set_vfta(hw, vid, true)) {
-               dev_err(&adapter->pdev->dev, "Failed to add vlan id %d\n", vid);
+               dev_warn(&adapter->pdev->dev, "Vlan id %d\n is not added", vid);
                spin_unlock_bh(&hw->mbx_lock);
                return -EINVAL;
        }
@@ -1520,7 +1520,7 @@ static void igbvf_reset(struct igbvf_adapter *adapter)
 
        /* Allow time for pending master requests to run */
        if (mac->ops.reset_hw(hw))
-               dev_err(&adapter->pdev->dev, "PF still resetting\n");
+               dev_warn(&adapter->pdev->dev, "PF still resetting\n");
 
        mac->ops.init_hw(hw);