projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0669631
)
ASoC: SDCA: Fix overwritten var within for loop
author
Maciej Strozek
<mstrozek@opensource.cirrus.com>
Wed, 8 Apr 2026 09:38:31 +0000
(10:38 +0100)
committer
Mark Brown
<broonie@kernel.org>
Wed, 8 Apr 2026 15:55:28 +0000
(16:55 +0100)
mask variable should not be overwritten within the for loop or it will
skip certain bits. Change to using BIT() macro.
Fixes:
b9ab3b618241
("ASoC: SDCA: Add some initial IRQ handlers")
Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link:
https://patch.msgid.link/20260408093835.2881486-2-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_interrupts.c
patch
|
blob
|
history
diff --git
a/sound/soc/sdca/sdca_interrupts.c
b/sound/soc/sdca/sdca_interrupts.c
index
1838dab
..
9acb0be
100644
(file)
--- a/
sound/soc/sdca/sdca_interrupts.c
+++ b/
sound/soc/sdca/sdca_interrupts.c
@@
-117,9
+117,7
@@
static irqreturn_t function_status_handler(int irq, void *data)
status = val;
for_each_set_bit(mask, &status, BITS_PER_BYTE) {
- mask = 1 << mask;
-
- switch (mask) {
+ switch (BIT(mask)) {
case SDCA_CTL_ENTITY_0_FUNCTION_NEEDS_INITIALIZATION:
//FIXME: Add init writes
break;