projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
56570bd
)
mtd: maps: pxa2xx-flash: fix memory leak in probe
author
Zheng Yongjun
<zhengyongjun3@huawei.com>
Sat, 19 Nov 2022 07:33:07 +0000
(07:33 +0000)
committer
Miquel Raynal
<miquel.raynal@bootlin.com>
Thu, 24 Nov 2022 11:33:38 +0000
(12:33 +0100)
Free 'info' upon remapping error to avoid a memory leak.
Fixes:
e644f7d62894
("[MTD] MAPS: Merge Lubbock and Mainstone drivers into common PXA2xx driver")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
[<miquel.raynal@bootlin.com>: Reword the commit log]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link:
https://lore.kernel.org/linux-mtd/20221119073307.22929-1-zhengyongjun3@huawei.com
drivers/mtd/maps/pxa2xx-flash.c
patch
|
blob
|
history
diff --git
a/drivers/mtd/maps/pxa2xx-flash.c
b/drivers/mtd/maps/pxa2xx-flash.c
index
1749dbb
..
62a5bf4
100644
(file)
--- a/
drivers/mtd/maps/pxa2xx-flash.c
+++ b/
drivers/mtd/maps/pxa2xx-flash.c
@@
-64,6
+64,7
@@
static int pxa2xx_flash_probe(struct platform_device *pdev)
if (!info->map.virt) {
printk(KERN_WARNING "Failed to ioremap %s\n",
info->map.name);
+ kfree(info);
return -ENOMEM;
}
info->map.cached = ioremap_cache(info->map.phys, info->map.size);
@@
-85,6
+86,7
@@
static int pxa2xx_flash_probe(struct platform_device *pdev)
iounmap((void *)info->map.virt);
if (info->map.cached)
iounmap(info->map.cached);
+ kfree(info);
return -EIO;
}
info->mtd->dev.parent = &pdev->dev;