i2c: dln2: Use dev_err_probe in probe function
authorLiao Chang <liaochang1@huawei.com>
Tue, 8 Aug 2023 01:29:52 +0000 (09:29 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 10 Aug 2023 08:13:40 +0000 (10:13 +0200)
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-8-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-dln2.c

index 4f02cc2..631109c 100644 (file)
@@ -218,10 +218,8 @@ static int dln2_i2c_probe(struct platform_device *pdev)
 
        /* initialize the i2c interface */
        ret = dln2_i2c_enable(dln2, true);
-       if (ret < 0) {
-               dev_err(dev, "failed to initialize adapter: %d\n", ret);
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "failed to initialize adapter\n");
 
        /* and finally attach to i2c layer */
        ret = i2c_add_adapter(&dln2->adapter);