clocksource/drivers/riscv: Events are stopped during CPU suspend
authorSamuel Holland <samuel@sholland.org>
Mon, 9 May 2022 01:21:21 +0000 (20:21 -0500)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 18 May 2022 09:08:52 +0000 (11:08 +0200)
Some implementations of the SBI time extension depend on hart-local
state (for example, CSRs) that are lost or hardware that is powered
down when a CPU is suspended. To be safe, the clockevents driver
cannot assume that timer IRQs will be received during CPU suspend.

Fixes: 62b019436814 ("clocksource: new RISC-V SBI timer driver")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20220509012121.40031-1-samuel@sholland.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/timer-riscv.c

index 1767f8b..593d5a9 100644 (file)
@@ -34,7 +34,7 @@ static int riscv_clock_next_event(unsigned long delta,
 static unsigned int riscv_clock_event_irq;
 static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = {
        .name                   = "riscv_timer_clockevent",
-       .features               = CLOCK_EVT_FEAT_ONESHOT,
+       .features               = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_C3STOP,
        .rating                 = 100,
        .set_next_event         = riscv_clock_next_event,
 };