mm: remove kzfree() compatibility definition
authorEric Biggers <ebiggers@google.com>
Fri, 23 Oct 2020 23:27:16 +0000 (16:27 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 25 Oct 2020 18:39:02 +0000 (11:39 -0700)
Commit 453431a54934 ("mm, treewide: rename kzfree() to
kfree_sensitive()") renamed kzfree() to kfree_sensitive(),
but it left a compatibility definition of kzfree() to avoid
being too disruptive.

Since then a few more instances of kzfree() have slipped in.

Just get rid of them and remove the compatibility definition
once and for all.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/staging/rtl8192e/rtllib_crypt_tkip.c
drivers/staging/rtl8192e/rtllib_crypt_wep.c
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
include/linux/slab.h
net/tipc/crypto.c

index 8c2ff37..238387d 100644 (file)
@@ -100,7 +100,7 @@ static void rtllib_tkip_deinit(void *priv)
                crypto_free_shash(_priv->tx_tfm_michael);
                crypto_free_shash(_priv->rx_tfm_michael);
        }
-       kzfree(priv);
+       kfree_sensitive(priv);
 }
 
 
index 7cdd17f..7790271 100644 (file)
@@ -49,7 +49,7 @@ static void *prism2_wep_init(int keyidx)
 
 static void prism2_wep_deinit(void *priv)
 {
-       kzfree(priv);
+       kfree_sensitive(priv);
 }
 
 /* Perform WEP encryption on given skb that has at least 4 bytes of headroom
index 4b415cc..e8fa1d3 100644 (file)
@@ -107,7 +107,7 @@ static void ieee80211_tkip_deinit(void *priv)
                crypto_free_shash(_priv->tx_tfm_michael);
                crypto_free_shash(_priv->rx_tfm_michael);
        }
-       kzfree(priv);
+       kfree_sensitive(priv);
 }
 
 
index 1c56e2d..a41b651 100644 (file)
@@ -54,7 +54,7 @@ static void *prism2_wep_init(int keyidx)
 
 static void prism2_wep_deinit(void *priv)
 {
-       kzfree(priv);
+       kfree_sensitive(priv);
 }
 
 /* Perform WEP encryption on given skb that has at least 4 bytes of headroom
index 9e155cc..dd6897f 100644 (file)
@@ -187,8 +187,6 @@ void kfree_sensitive(const void *);
 size_t __ksize(const void *);
 size_t ksize(const void *);
 
-#define kzfree(x)      kfree_sensitive(x)      /* For backward compatibility */
-
 #ifdef CONFIG_HAVE_HARDENED_USERCOPY_ALLOCATOR
 void __check_heap_object(const void *ptr, unsigned long n, struct page *page,
                        bool to_user);
index 40c4410..740ab9a 100644 (file)
@@ -418,7 +418,7 @@ static void tipc_aead_free(struct rcu_head *rp)
                kfree(head);
        }
        free_percpu(aead->tfm_entry);
-       kzfree(aead->key);
+       kfree_sensitive(aead->key);
        kfree(aead);
 }
 
@@ -2452,7 +2452,7 @@ static void tipc_crypto_work_tx(struct work_struct *work)
                     tipc_crypto_key_init(tx, skey, PER_NODE_KEY, false);
                if (likely(rc > 0))
                        rc = tipc_crypto_key_distr(tx, rc, NULL);
-               kzfree(skey);
+               kfree_sensitive(skey);
        }
 
        if (unlikely(rc))