ipe: add userspace interface
authorDeven Bowers <deven.desai@linux.microsoft.com>
Sat, 3 Aug 2024 06:08:22 +0000 (23:08 -0700)
committerPaul Moore <paul@paul-moore.com>
Tue, 20 Aug 2024 18:02:15 +0000 (14:02 -0400)
As is typical with LSMs, IPE uses securityfs as its interface with
userspace. for a complete list of the interfaces and the respective
inputs/outputs, please see the documentation under
admin-guide/LSM/ipe.rst

Signed-off-by: Deven Bowers <deven.desai@linux.microsoft.com>
Signed-off-by: Fan Wu <wufan@linux.microsoft.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/ipe/Makefile
security/ipe/fs.c [new file with mode: 0644]
security/ipe/fs.h [new file with mode: 0644]
security/ipe/ipe.c
security/ipe/ipe.h
security/ipe/policy.c
security/ipe/policy.h
security/ipe/policy_fs.c [new file with mode: 0644]

index e1c27e9..b97f8c1 100644 (file)
@@ -8,6 +8,8 @@
 obj-$(CONFIG_SECURITY_IPE) += \
        eval.o \
        hooks.o \
+       fs.o \
        ipe.o \
        policy.o \
+       policy_fs.o \
        policy_parser.o \
diff --git a/security/ipe/fs.c b/security/ipe/fs.c
new file mode 100644 (file)
index 0000000..49484c8
--- /dev/null
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2020-2024 Microsoft Corporation. All rights reserved.
+ */
+
+#include <linux/dcache.h>
+#include <linux/security.h>
+
+#include "ipe.h"
+#include "fs.h"
+#include "policy.h"
+
+static struct dentry *np __ro_after_init;
+static struct dentry *root __ro_after_init;
+struct dentry *policy_root __ro_after_init;
+
+/**
+ * new_policy() - Write handler for the securityfs node, "ipe/new_policy".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-EPERM                   - Insufficient permission
+ * * %-ENOMEM                  - Out of memory (OOM)
+ * * %-EBADMSG                 - Policy is invalid
+ * * %-ERANGE                  - Policy version number overflow
+ * * %-EINVAL                  - Policy version parsing error
+ * * %-EEXIST                  - Same name policy already deployed
+ */
+static ssize_t new_policy(struct file *f, const char __user *data,
+                         size_t len, loff_t *offset)
+{
+       struct ipe_policy *p = NULL;
+       char *copy = NULL;
+       int rc = 0;
+
+       if (!file_ns_capable(f, &init_user_ns, CAP_MAC_ADMIN))
+               return -EPERM;
+
+       copy = memdup_user_nul(data, len);
+       if (IS_ERR(copy))
+               return PTR_ERR(copy);
+
+       p = ipe_new_policy(NULL, 0, copy, len);
+       if (IS_ERR(p)) {
+               rc = PTR_ERR(p);
+               goto out;
+       }
+
+       rc = ipe_new_policyfs_node(p);
+
+out:
+       if (rc < 0)
+               ipe_free_policy(p);
+       kfree(copy);
+       return (rc < 0) ? rc : len;
+}
+
+static const struct file_operations np_fops = {
+       .write = new_policy,
+};
+
+/**
+ * ipe_init_securityfs() - Initialize IPE's securityfs tree at fsinit.
+ *
+ * Return: %0 on success. If an error occurs, the function will return
+ * the -errno.
+ */
+static int __init ipe_init_securityfs(void)
+{
+       int rc = 0;
+
+       if (!ipe_enabled)
+               return -EOPNOTSUPP;
+
+       root = securityfs_create_dir("ipe", NULL);
+       if (IS_ERR(root)) {
+               rc = PTR_ERR(root);
+               goto err;
+       }
+
+       policy_root = securityfs_create_dir("policies", root);
+       if (IS_ERR(policy_root)) {
+               rc = PTR_ERR(policy_root);
+               goto err;
+       }
+
+       np = securityfs_create_file("new_policy", 0200, root, NULL, &np_fops);
+       if (IS_ERR(np)) {
+               rc = PTR_ERR(np);
+               goto err;
+       }
+
+       return 0;
+err:
+       securityfs_remove(np);
+       securityfs_remove(policy_root);
+       securityfs_remove(root);
+       return rc;
+}
+
+fs_initcall(ipe_init_securityfs);
diff --git a/security/ipe/fs.h b/security/ipe/fs.h
new file mode 100644 (file)
index 0000000..0141ae8
--- /dev/null
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2020-2024 Microsoft Corporation. All rights reserved.
+ */
+
+#ifndef _IPE_FS_H
+#define _IPE_FS_H
+
+#include "policy.h"
+
+extern struct dentry *policy_root __ro_after_init;
+
+int ipe_new_policyfs_node(struct ipe_policy *p);
+void ipe_del_policyfs_node(struct ipe_policy *p);
+
+#endif /* _IPE_FS_H */
index 28555ea..53f2196 100644 (file)
@@ -8,6 +8,8 @@
 #include "eval.h"
 #include "hooks.h"
 
+bool ipe_enabled;
+
 static struct lsm_blob_sizes ipe_blobs __ro_after_init = {
        .lbs_superblock = sizeof(struct ipe_superblock),
 };
@@ -45,6 +47,7 @@ static struct security_hook_list ipe_hooks[] __ro_after_init = {
 static int __init ipe_init(void)
 {
        security_add_hooks(ipe_hooks, ARRAY_SIZE(ipe_hooks), &ipe_lsmid);
+       ipe_enabled = true;
 
        return 0;
 }
index 7f1c818..4aa18d1 100644 (file)
@@ -14,4 +14,6 @@
 #include <linux/lsm_hooks.h>
 struct ipe_superblock *ipe_sb(const struct super_block *sb);
 
+extern bool ipe_enabled;
+
 #endif /* _IPE_H */
index dd7b5b7..be9808b 100644 (file)
@@ -7,9 +7,36 @@
 #include <linux/verification.h>
 
 #include "ipe.h"
+#include "eval.h"
+#include "fs.h"
 #include "policy.h"
 #include "policy_parser.h"
 
+/* lock for synchronizing writers across ipe policy */
+DEFINE_MUTEX(ipe_policy_lock);
+
+/**
+ * ver_to_u64() - Convert an internal ipe_policy_version to a u64.
+ * @p: Policy to extract the version from.
+ *
+ * Bits (LSB is index 0):
+ *     [48,32] -> Major
+ *     [32,16] -> Minor
+ *     [16, 0] -> Revision
+ *
+ * Return: u64 version of the embedded version structure.
+ */
+static inline u64 ver_to_u64(const struct ipe_policy *const p)
+{
+       u64 r;
+
+       r = (((u64)p->parsed->version.major) << 32)
+         | (((u64)p->parsed->version.minor) << 16)
+         | ((u64)(p->parsed->version.rev));
+
+       return r;
+}
+
 /**
  * ipe_free_policy() - Deallocate a given IPE policy.
  * @p: Supplies the policy to free.
@@ -21,6 +48,7 @@ void ipe_free_policy(struct ipe_policy *p)
        if (IS_ERR_OR_NULL(p))
                return;
 
+       ipe_del_policyfs_node(p);
        ipe_free_parsed_policy(p->parsed);
        /*
         * p->text is allocated only when p->pkcs7 is not NULL
@@ -43,6 +71,66 @@ static int set_pkcs7_data(void *ctx, const void *data, size_t len,
        return 0;
 }
 
+/**
+ * ipe_update_policy() - parse a new policy and replace old with it.
+ * @root: Supplies a pointer to the securityfs inode saved the policy.
+ * @text: Supplies a pointer to the plain text policy.
+ * @textlen: Supplies the length of @text.
+ * @pkcs7: Supplies a pointer to a buffer containing a pkcs7 message.
+ * @pkcs7len: Supplies the length of @pkcs7len.
+ *
+ * @text/@textlen is mutually exclusive with @pkcs7/@pkcs7len - see
+ * ipe_new_policy.
+ *
+ * Context: Requires root->i_rwsem to be held.
+ * Return: %0 on success. If an error occurs, the function will return
+ * the -errno.
+ */
+int ipe_update_policy(struct inode *root, const char *text, size_t textlen,
+                     const char *pkcs7, size_t pkcs7len)
+{
+       struct ipe_policy *old, *ap, *new = NULL;
+       int rc = 0;
+
+       old = (struct ipe_policy *)root->i_private;
+       if (!old)
+               return -ENOENT;
+
+       new = ipe_new_policy(text, textlen, pkcs7, pkcs7len);
+       if (IS_ERR(new))
+               return PTR_ERR(new);
+
+       if (strcmp(new->parsed->name, old->parsed->name)) {
+               rc = -EINVAL;
+               goto err;
+       }
+
+       if (ver_to_u64(old) > ver_to_u64(new)) {
+               rc = -EINVAL;
+               goto err;
+       }
+
+       root->i_private = new;
+       swap(new->policyfs, old->policyfs);
+
+       mutex_lock(&ipe_policy_lock);
+       ap = rcu_dereference_protected(ipe_active_policy,
+                                      lockdep_is_held(&ipe_policy_lock));
+       if (old == ap) {
+               rcu_assign_pointer(ipe_active_policy, new);
+               mutex_unlock(&ipe_policy_lock);
+       } else {
+               mutex_unlock(&ipe_policy_lock);
+       }
+       synchronize_rcu();
+       ipe_free_policy(old);
+
+       return 0;
+err:
+       ipe_free_policy(new);
+       return rc;
+}
+
 /**
  * ipe_new_policy() - Allocate and parse an ipe_policy structure.
  *
@@ -101,3 +189,35 @@ err:
        ipe_free_policy(new);
        return ERR_PTR(rc);
 }
+
+/**
+ * ipe_set_active_pol() - Make @p the active policy.
+ * @p: Supplies a pointer to the policy to make active.
+ *
+ * Context: Requires root->i_rwsem, which i_private has the policy, to be held.
+ * Return:
+ * * %0        - Success
+ * * %-EINVAL  - New active policy version is invalid
+ */
+int ipe_set_active_pol(const struct ipe_policy *p)
+{
+       struct ipe_policy *ap = NULL;
+
+       mutex_lock(&ipe_policy_lock);
+
+       ap = rcu_dereference_protected(ipe_active_policy,
+                                      lockdep_is_held(&ipe_policy_lock));
+       if (ap == p) {
+               mutex_unlock(&ipe_policy_lock);
+               return 0;
+       }
+       if (ap && ver_to_u64(ap) > ver_to_u64(p)) {
+               mutex_unlock(&ipe_policy_lock);
+               return -EINVAL;
+       }
+
+       rcu_assign_pointer(ipe_active_policy, p);
+       mutex_unlock(&ipe_policy_lock);
+
+       return 0;
+}
index 69ca8cd..ffd60cc 100644 (file)
@@ -7,6 +7,7 @@
 
 #include <linux/list.h>
 #include <linux/types.h>
+#include <linux/fs.h>
 
 enum ipe_op_type {
        IPE_OP_EXEC = 0,
@@ -76,10 +77,16 @@ struct ipe_policy {
        size_t textlen;
 
        struct ipe_parsed_policy *parsed;
+
+       struct dentry *policyfs;
 };
 
 struct ipe_policy *ipe_new_policy(const char *text, size_t textlen,
                                  const char *pkcs7, size_t pkcs7len);
 void ipe_free_policy(struct ipe_policy *pol);
+int ipe_update_policy(struct inode *root, const char *text, size_t textlen,
+                     const char *pkcs7, size_t pkcs7len);
+int ipe_set_active_pol(const struct ipe_policy *p);
+extern struct mutex ipe_policy_lock;
 
 #endif /* _IPE_POLICY_H */
diff --git a/security/ipe/policy_fs.c b/security/ipe/policy_fs.c
new file mode 100644 (file)
index 0000000..3bcd8cb
--- /dev/null
@@ -0,0 +1,472 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2020-2024 Microsoft Corporation. All rights reserved.
+ */
+#include <linux/fs.h>
+#include <linux/namei.h>
+#include <linux/types.h>
+#include <linux/dcache.h>
+#include <linux/security.h>
+
+#include "ipe.h"
+#include "policy.h"
+#include "eval.h"
+#include "fs.h"
+
+#define MAX_VERSION_SIZE ARRAY_SIZE("65535.65535.65535")
+
+/**
+ * ipefs_file - defines a file in securityfs.
+ */
+struct ipefs_file {
+       const char *name;
+       umode_t access;
+       const struct file_operations *fops;
+};
+
+/**
+ * read_pkcs7() - Read handler for "ipe/policies/$name/pkcs7".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * @data will be populated with the pkcs7 blob representing the policy
+ * on success. If the policy is unsigned (like the boot policy), this
+ * will return -ENOENT.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-ENOENT                  - Policy initializing/deleted or is unsigned
+ */
+static ssize_t read_pkcs7(struct file *f, char __user *data,
+                         size_t len, loff_t *offset)
+{
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       int rc = 0;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+
+       inode_lock_shared(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       if (!p->pkcs7) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       rc = simple_read_from_buffer(data, len, offset, p->pkcs7, p->pkcs7len);
+
+out:
+       inode_unlock_shared(root);
+
+       return rc;
+}
+
+/**
+ * read_policy() - Read handler for "ipe/policies/$name/policy".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * @data will be populated with the plain-text version of the policy
+ * on success.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t read_policy(struct file *f, char __user *data,
+                          size_t len, loff_t *offset)
+{
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       int rc = 0;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+
+       inode_lock_shared(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       rc = simple_read_from_buffer(data, len, offset, p->text, p->textlen);
+
+out:
+       inode_unlock_shared(root);
+
+       return rc;
+}
+
+/**
+ * read_name() - Read handler for "ipe/policies/$name/name".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * @data will be populated with the policy_name attribute on success.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t read_name(struct file *f, char __user *data,
+                        size_t len, loff_t *offset)
+{
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       int rc = 0;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+
+       inode_lock_shared(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       rc = simple_read_from_buffer(data, len, offset, p->parsed->name,
+                                    strlen(p->parsed->name));
+
+out:
+       inode_unlock_shared(root);
+
+       return rc;
+}
+
+/**
+ * read_version() - Read handler for "ipe/policies/$name/version".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * @data will be populated with the version string on success.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t read_version(struct file *f, char __user *data,
+                           size_t len, loff_t *offset)
+{
+       char buffer[MAX_VERSION_SIZE] = { 0 };
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       size_t strsize = 0;
+       ssize_t rc = 0;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+
+       inode_lock_shared(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       strsize = scnprintf(buffer, ARRAY_SIZE(buffer), "%hu.%hu.%hu",
+                           p->parsed->version.major, p->parsed->version.minor,
+                           p->parsed->version.rev);
+
+       rc = simple_read_from_buffer(data, len, offset, buffer, strsize);
+
+out:
+       inode_unlock_shared(root);
+
+       return rc;
+}
+
+/**
+ * setactive() - Write handler for "ipe/policies/$name/active".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-EPERM                   - Insufficient permission
+ * * %-EINVAL                  - Invalid input
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t setactive(struct file *f, const char __user *data,
+                        size_t len, loff_t *offset)
+{
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       bool value = false;
+       int rc = 0;
+
+       if (!file_ns_capable(f, &init_user_ns, CAP_MAC_ADMIN))
+               return -EPERM;
+
+       rc = kstrtobool_from_user(data, len, &value);
+       if (rc)
+               return rc;
+
+       if (!value)
+               return -EINVAL;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+       inode_lock(root);
+
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               rc = -ENOENT;
+               goto out;
+       }
+
+       rc = ipe_set_active_pol(p);
+
+out:
+       inode_unlock(root);
+       return (rc < 0) ? rc : len;
+}
+
+/**
+ * getactive() - Read handler for "ipe/policies/$name/active".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * @data will be populated with the 1 or 0 depending on if the
+ * corresponding policy is active.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t getactive(struct file *f, char __user *data,
+                        size_t len, loff_t *offset)
+{
+       const struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       const char *str;
+       int rc = 0;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+
+       inode_lock_shared(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               inode_unlock_shared(root);
+               return -ENOENT;
+       }
+       inode_unlock_shared(root);
+
+       str = (p == rcu_access_pointer(ipe_active_policy)) ? "1" : "0";
+       rc = simple_read_from_buffer(data, len, offset, str, 1);
+
+       return rc;
+}
+
+/**
+ * update_policy() - Write handler for "ipe/policies/$name/update".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * On success this updates the policy represented by $name,
+ * in-place.
+ *
+ * Return: Length of buffer written on success. If an error occurs,
+ * the function will return the -errno.
+ */
+static ssize_t update_policy(struct file *f, const char __user *data,
+                            size_t len, loff_t *offset)
+{
+       struct inode *root = NULL;
+       char *copy = NULL;
+       int rc = 0;
+
+       if (!file_ns_capable(f, &init_user_ns, CAP_MAC_ADMIN))
+               return -EPERM;
+
+       copy = memdup_user(data, len);
+       if (IS_ERR(copy))
+               return PTR_ERR(copy);
+
+       root = d_inode(f->f_path.dentry->d_parent);
+       inode_lock(root);
+       rc = ipe_update_policy(root, NULL, 0, copy, len);
+       inode_unlock(root);
+
+       kfree(copy);
+       if (rc)
+               return rc;
+
+       return len;
+}
+
+/**
+ * delete_policy() - write handler for  "ipe/policies/$name/delete".
+ * @f: Supplies a file structure representing the securityfs node.
+ * @data: Supplies a buffer passed to the write syscall.
+ * @len: Supplies the length of @data.
+ * @offset: unused.
+ *
+ * On success this deletes the policy represented by $name.
+ *
+ * Return:
+ * * Length of buffer written  - Success
+ * * %-EPERM                   - Insufficient permission/deleting active policy
+ * * %-EINVAL                  - Invalid input
+ * * %-ENOENT                  - Policy initializing/deleted
+ */
+static ssize_t delete_policy(struct file *f, const char __user *data,
+                            size_t len, loff_t *offset)
+{
+       struct ipe_policy *ap = NULL;
+       struct ipe_policy *p = NULL;
+       struct inode *root = NULL;
+       bool value = false;
+       int rc = 0;
+
+       if (!file_ns_capable(f, &init_user_ns, CAP_MAC_ADMIN))
+               return -EPERM;
+
+       rc = kstrtobool_from_user(data, len, &value);
+       if (rc)
+               return rc;
+
+       if (!value)
+               return -EINVAL;
+
+       root = d_inode(f->f_path.dentry->d_parent);
+       inode_lock(root);
+       p = (struct ipe_policy *)root->i_private;
+       if (!p) {
+               inode_unlock(root);
+               return -ENOENT;
+       }
+
+       mutex_lock(&ipe_policy_lock);
+       ap = rcu_dereference_protected(ipe_active_policy,
+                                      lockdep_is_held(&ipe_policy_lock));
+       if (p == ap) {
+               mutex_unlock(&ipe_policy_lock);
+               inode_unlock(root);
+               return -EPERM;
+       }
+       mutex_unlock(&ipe_policy_lock);
+
+       root->i_private = NULL;
+       inode_unlock(root);
+
+       synchronize_rcu();
+       ipe_free_policy(p);
+
+       return len;
+}
+
+static const struct file_operations content_fops = {
+       .read = read_policy,
+};
+
+static const struct file_operations pkcs7_fops = {
+       .read = read_pkcs7,
+};
+
+static const struct file_operations name_fops = {
+       .read = read_name,
+};
+
+static const struct file_operations ver_fops = {
+       .read = read_version,
+};
+
+static const struct file_operations active_fops = {
+       .write = setactive,
+       .read = getactive,
+};
+
+static const struct file_operations update_fops = {
+       .write = update_policy,
+};
+
+static const struct file_operations delete_fops = {
+       .write = delete_policy,
+};
+
+/**
+ * policy_subdir - files under a policy subdirectory
+ */
+static const struct ipefs_file policy_subdir[] = {
+       { "pkcs7", 0444, &pkcs7_fops },
+       { "policy", 0444, &content_fops },
+       { "name", 0444, &name_fops },
+       { "version", 0444, &ver_fops },
+       { "active", 0600, &active_fops },
+       { "update", 0200, &update_fops },
+       { "delete", 0200, &delete_fops },
+};
+
+/**
+ * ipe_del_policyfs_node() - Delete a securityfs entry for @p.
+ * @p: Supplies a pointer to the policy to delete a securityfs entry for.
+ */
+void ipe_del_policyfs_node(struct ipe_policy *p)
+{
+       securityfs_recursive_remove(p->policyfs);
+       p->policyfs = NULL;
+}
+
+/**
+ * ipe_new_policyfs_node() - Create a securityfs entry for @p.
+ * @p: Supplies a pointer to the policy to create a securityfs entry for.
+ *
+ * Return: %0 on success. If an error occurs, the function will return
+ * the -errno.
+ */
+int ipe_new_policyfs_node(struct ipe_policy *p)
+{
+       const struct ipefs_file *f = NULL;
+       struct dentry *policyfs = NULL;
+       struct inode *root = NULL;
+       struct dentry *d = NULL;
+       size_t i = 0;
+       int rc = 0;
+
+       if (p->policyfs)
+               return 0;
+
+       policyfs = securityfs_create_dir(p->parsed->name, policy_root);
+       if (IS_ERR(policyfs))
+               return PTR_ERR(policyfs);
+
+       root = d_inode(policyfs);
+
+       for (i = 0; i < ARRAY_SIZE(policy_subdir); ++i) {
+               f = &policy_subdir[i];
+
+               d = securityfs_create_file(f->name, f->access, policyfs,
+                                          NULL, f->fops);
+               if (IS_ERR(d)) {
+                       rc = PTR_ERR(d);
+                       goto err;
+               }
+       }
+
+       inode_lock(root);
+       p->policyfs = policyfs;
+       root->i_private = p;
+       inode_unlock(root);
+
+       return 0;
+err:
+       securityfs_recursive_remove(policyfs);
+       return rc;
+}