scsi: qla2xxx: Initialize variable in qla8044_poll_reg()
authorTom Rix <trix@redhat.com>
Mon, 5 Oct 2020 14:45:44 +0000 (07:45 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 8 Oct 2020 03:50:03 +0000 (23:50 -0400)
clang static analysis reports this problem:

qla_nx2.c:694:3: warning: 6th function call argument is
  an uninitialized value
        ql_log(ql_log_fatal, vha, 0xb090,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In qla8044_poll_reg(), when reading the reg fails, the error is reported by
reusing the timeout error reporter.  Because the value is unset, a garbage
value will be reported.  Initialize the value.

Link: https://lore.kernel.org/r/20201005144544.25335-1-trix@redhat.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nx2.c

index 50e5760..36cbd72 100644 (file)
@@ -660,7 +660,7 @@ static int
 qla8044_poll_reg(struct scsi_qla_host *vha, uint32_t addr,
        int duration, uint32_t test_mask, uint32_t test_result)
 {
-       uint32_t value;
+       uint32_t value = 0;
        int timeout_error;
        uint8_t retries;
        int ret_val = QLA_SUCCESS;