drm/i915: Eliminate crtc->state usage from intel_atomic_commit_tail and .crtc_update()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 23 Aug 2017 15:22:26 +0000 (18:22 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 1 Sep 2017 13:52:22 +0000 (16:52 +0300)
We already have the correct new crtc state so just use that instead of
crtc->state.

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170823152226.22938-7-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/intel_display.c

index 8e1eb09..216cd9e 100644 (file)
@@ -12281,7 +12281,7 @@ static void skl_update_crtcs(struct drm_atomic_state *state,
                        unsigned int cmask = drm_crtc_mask(crtc);
 
                        intel_crtc = to_intel_crtc(crtc);
-                       cstate = to_intel_crtc_state(crtc->state);
+                       cstate = to_intel_crtc_state(new_crtc_state);
                        pipe = intel_crtc->pipe;
 
                        if (updated & cmask || !cstate->base.active)
@@ -12410,7 +12410,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
                        intel_check_cpu_fifo_underruns(dev_priv);
                        intel_check_pch_fifo_underruns(dev_priv);
 
-                       if (!crtc->state->active) {
+                       if (!new_crtc_state->active) {
                                /*
                                 * Make sure we don't call initial_watermarks
                                 * for ILK-style watermark updates.
@@ -12419,7 +12419,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
                                 */
                                if (INTEL_GEN(dev_priv) >= 9)
                                        dev_priv->display.initial_watermarks(intel_state,
-                                                                            to_intel_crtc_state(crtc->state));
+                                                                            to_intel_crtc_state(new_crtc_state));
                        }
                }
        }