RDMA/hw/qib/qib_user_pages: remove FOLL_FORCE usage
authorDavid Hildenbrand <david@redhat.com>
Wed, 16 Nov 2022 10:26:57 +0000 (11:26 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 30 Nov 2022 23:59:00 +0000 (15:59 -0800)
FOLL_FORCE is really only for ptrace access. As we unpin the pinned pages
using unpin_user_pages_dirty_lock(true), the assumption is that all these
pages are writable.

FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove
it.

Link: https://lkml.kernel.org/r/20221116102659.70287-19-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/infiniband/hw/qib/qib_user_pages.c

index f4b5f05..f693bc7 100644 (file)
@@ -110,7 +110,7 @@ int qib_get_user_pages(unsigned long start_page, size_t num_pages,
        for (got = 0; got < num_pages; got += ret) {
                ret = pin_user_pages(start_page + got * PAGE_SIZE,
                                     num_pages - got,
-                                    FOLL_LONGTERM | FOLL_WRITE | FOLL_FORCE,
+                                    FOLL_LONGTERM | FOLL_WRITE,
                                     p + got, NULL);
                if (ret < 0) {
                        mmap_read_unlock(current->mm);