Input: sparcspkr - use cleanup facility for device_node
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 21 Oct 2024 20:28:24 +0000 (22:28 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 22 Oct 2024 20:58:39 +0000 (13:58 -0700)
Use the 'free(device_node)' macro to simplify the code by automatically
freeing the device node, which removes the need for explicit calls to
'of_node_put()'.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20241021-input_automate_of_node_put-v3-2-cc73f636e1bc@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/sparcspkr.c

index e484d79..8d7303f 100644 (file)
@@ -182,7 +182,6 @@ static int bbc_beep_probe(struct platform_device *op)
 {
        struct sparcspkr_state *state;
        struct bbc_beep_info *info;
-       struct device_node *dp;
        int err;
 
        state = devm_kzalloc(&op->dev, sizeof(*state), GFP_KERNEL);
@@ -193,13 +192,12 @@ static int bbc_beep_probe(struct platform_device *op)
        state->event = bbc_spkr_event;
        spin_lock_init(&state->lock);
 
-       dp = of_find_node_by_path("/");
+       struct device_node *dp __free(device_node) = of_find_node_by_path("/");
        if (!dp)
                return -ENODEV;
 
        info = &state->u.bbc;
        info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0);
-       of_node_put(dp);
        if (!info->clock_freq)
                return -ENODEV;