drm/amd/display: Remove redundant condition in VBA 314 func
authorIvan Lipski <ivlipski@amd.com>
Tue, 4 Jun 2024 14:28:05 +0000 (10:28 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:18:54 +0000 (16:18 -0400)
[WHY]
Coverity analysis this conditional code as DEADCODE.
The conditional statement is never true since
'MacroTileSizeBytes' is either 256 or 65536. Thus, the
code inside is the conditional statement is never reached.

[HOW]
Removed the conditional statement.

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Ivan Lipski <ivlipski@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c

index f52b9e3..cb50c47 100644 (file)
@@ -1941,15 +1941,6 @@ static unsigned int CalculateVMAndRowBytes(
                *PixelPTEReqWidth = 32768.0 / BytePerPixel;
                *PTERequestSize = 64;
                FractionOfPTEReturnDrop = 0;
-       } else if (MacroTileSizeBytes == 4096) {
-               PixelPTEReqHeightPTEs = 1;
-               *PixelPTEReqHeight = MacroTileHeight;
-               *PixelPTEReqWidth = 8 * *MacroTileWidth;
-               *PTERequestSize = 64;
-               if (ScanDirection != dm_vert)
-                       FractionOfPTEReturnDrop = 0;
-               else
-                       FractionOfPTEReturnDrop = 7 / 8;
        } else if (GPUVMMinPageSize == 4 && MacroTileSizeBytes > 4096) {
                PixelPTEReqHeightPTEs = 16;
                *PixelPTEReqHeight = 16 * BlockHeight256Bytes;