net: cosa: replace comparison to NULL with "!chan->rx_skb"
authorPeng Li <lipeng321@huawei.com>
Wed, 16 Jun 2021 07:23:30 +0000 (15:23 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jun 2021 07:52:33 +0000 (00:52 -0700)
According to the chackpatch.pl, comparison to NULL could
be written "!chan->rx_skb".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/cosa.c

index c051c61..7b57233 100644 (file)
@@ -719,7 +719,7 @@ static char *cosa_net_setup_rx(struct channel_data *chan, int size)
         */
        kfree_skb(chan->rx_skb);
        chan->rx_skb = dev_alloc_skb(size);
-       if (chan->rx_skb == NULL) {
+       if (!chan->rx_skb) {
                pr_notice("%s: Memory squeeze, dropping packet\n", chan->name);
                chan->netdev->stats.rx_dropped++;
                return NULL;
@@ -783,7 +783,7 @@ static ssize_t cosa_read(struct file *file,
                return -ERESTARTSYS;
        
        chan->rxdata = kmalloc(COSA_MTU, GFP_DMA|GFP_KERNEL);
-       if (chan->rxdata == NULL) {
+       if (!chan->rxdata) {
                mutex_unlock(&chan->rlock);
                return -ENOMEM;
        }
@@ -861,7 +861,7 @@ static ssize_t cosa_write(struct file *file,
        
        /* Allocate the buffer */
        kbuf = kmalloc(count, GFP_KERNEL|GFP_DMA);
-       if (kbuf == NULL) {
+       if (!kbuf) {
                up(&chan->wsem);
                return -ENOMEM;
        }