ixgbe: reduce checker warnings
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Fri, 26 Mar 2021 00:38:34 +0000 (17:38 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 26 May 2021 16:11:41 +0000 (09:11 -0700)
Fix the sparse warnings in the ixgbe crypto offload code. These
changes were made in the most conservative way (force cast)
in order to hopefully not break the code. I suspect that the
code might still be broken on big-endian architectures, but
no one is complaining, so I'm just leaving it functionally
the same.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Shannon Nelson <snelson@pensando.io>
Tested-by: Dave Switzer <david.switzer@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c

index 54d4726..e596e1a 100644 (file)
@@ -511,14 +511,14 @@ static int ixgbe_ipsec_check_mgmt_ip(struct xfrm_state *xs)
                                        continue;
 
                                reg = IXGBE_READ_REG(hw, MIPAF_ARR(3, i));
-                               if (reg == xs->id.daddr.a4)
+                               if (reg == (__force u32)xs->id.daddr.a4)
                                        return 1;
                        }
                }
 
                if ((bmcipval & BMCIP_MASK) == BMCIP_V4) {
                        reg = IXGBE_READ_REG(hw, IXGBE_BMCIP(3));
-                       if (reg == xs->id.daddr.a4)
+                       if (reg == (__force u32)xs->id.daddr.a4)
                                return 1;
                }
 
@@ -533,7 +533,7 @@ static int ixgbe_ipsec_check_mgmt_ip(struct xfrm_state *xs)
 
                        for (j = 0; j < 4; j++) {
                                reg = IXGBE_READ_REG(hw, MIPAF_ARR(i, j));
-                               if (reg != xs->id.daddr.a6[j])
+                               if (reg != (__force u32)xs->id.daddr.a6[j])
                                        break;
                        }
                        if (j == 4)   /* did we match all 4 words? */
@@ -543,7 +543,7 @@ static int ixgbe_ipsec_check_mgmt_ip(struct xfrm_state *xs)
                if ((bmcipval & BMCIP_MASK) == BMCIP_V6) {
                        for (j = 0; j < 4; j++) {
                                reg = IXGBE_READ_REG(hw, IXGBE_BMCIP(j));
-                               if (reg != xs->id.daddr.a6[j])
+                               if (reg != (__force u32)xs->id.daddr.a6[j])
                                        break;
                        }
                        if (j == 4)   /* did we match all 4 words? */