ALSA: oxygen: Delete an unnecessary check before the function call "snd_pcm_suspend"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jan 2015 16:37:28 +0000 (17:37 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 4 Jan 2015 14:12:20 +0000 (15:12 +0100)
The snd_pcm_suspend() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/oxygen/oxygen_lib.c

index b67e306..61a62c0 100644 (file)
@@ -736,8 +736,7 @@ static int oxygen_pci_suspend(struct device *dev)
        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
 
        for (i = 0; i < PCM_COUNT; ++i)
-               if (chip->streams[i])
-                       snd_pcm_suspend(chip->streams[i]);
+               snd_pcm_suspend(chip->streams[i]);
 
        if (chip->model.suspend)
                chip->model.suspend(chip);