target: Fix two debugprints that appear to be wrong
authorAndy Grover <agrover@redhat.com>
Thu, 16 May 2013 17:40:56 +0000 (10:40 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 14 Jun 2013 07:04:35 +0000 (00:04 -0700)
They're in emulate_pro_register, so change UNREGISTER to REGISTER.

The first one seems wrong -- sa_res_key could be 0 there, but it's testing
spec_i_pt.

Remove unneeded parens  in 2nd conditional.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_pr.c

index f776368..c797e79 100644 (file)
@@ -2151,8 +2151,8 @@ core_scsi3_emulate_pro_register(struct se_cmd *cmd, u64 res_key, u64 sa_res_key,
        }
 
        if (spec_i_pt) {
-               pr_err("SPC-3 PR UNREGISTER: SPEC_I_PT"
-                       " set while sa_res_key=0\n");
+               pr_err("SPC-3 PR REGISTER: SPEC_I_PT"
+                       " set on a registered nexus\n");
                ret = TCM_INVALID_PARAMETER_LIST;
                goto out_put_pr_reg;
        }
@@ -2161,8 +2161,8 @@ core_scsi3_emulate_pro_register(struct se_cmd *cmd, u64 res_key, u64 sa_res_key,
         * An existing ALL_TG_PT=1 registration being released
         * must also set ALL_TG_PT=1 in the incoming PROUT.
         */
-       if (pr_reg->pr_reg_all_tg_pt && !(all_tg_pt)) {
-               pr_err("SPC-3 PR UNREGISTER: ALL_TG_PT=1"
+       if (pr_reg->pr_reg_all_tg_pt && !all_tg_pt) {
+               pr_err("SPC-3 PR REGISTER: ALL_TG_PT=1"
                        " registration exists, but ALL_TG_PT=1 bit not"
                        " present in received PROUT\n");
                ret = TCM_INVALID_CDB_FIELD;