bnxt_en: Remove unneeded variable in bnxt_hwrm_clear_vnic_filter()
authorMichael Chan <michael.chan@broadcom.com>
Fri, 5 Jan 2024 23:54:37 +0000 (15:54 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Jan 2024 03:15:02 +0000 (19:15 -0800)
After recent refactoring, this function doesn't return error any
more.  Remove the unneeded rc variable and change the function to
void.  The caller is not checking for the return value.

Fixes: 96c9bedc755e ("bnxt_en: Refactor L2 filter alloc/free firmware commands.")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401041942.qrB1amZM-lkp@intel.com/
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240105235439.28282-2-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index b70ddd3..fb5af8a 100644 (file)
@@ -5752,10 +5752,9 @@ static int bnxt_hwrm_set_vnic_filter(struct bnxt *bp, u16 vnic_id, u16 idx,
        return rc;
 }
 
-static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp)
+static void bnxt_hwrm_clear_vnic_filter(struct bnxt *bp)
 {
        u16 i, j, num_of_vnics = 1; /* only vnic 0 supported */
-       int rc = 0;
 
        /* Any associated ntuple filters will also be cleared by firmware. */
        for (i = 0; i < num_of_vnics; i++) {
@@ -5769,8 +5768,6 @@ static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp)
                }
                vnic->uc_filter_count = 0;
        }
-
-       return rc;
 }
 
 #define BNXT_DFLT_TUNL_TPA_BMAP                                \