drm/i915/hangcheck: Look at instdone for all engines
authorTvrtko Ursulin <tvrtko.ursulin@intel.com>
Wed, 3 Jul 2019 14:41:16 +0000 (15:41 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 4 Jul 2019 21:53:12 +0000 (22:53 +0100)
It seems intel_engine_get_instdone is able to get instdone for all engines
but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.

We can just drop the check in subunits_stuck since the checks on
unavailable fields will always return stuck, which when bitwise and with
the potential unstuck instdone is harmless.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190703144116.15593-1-tvrtko.ursulin@linux.intel.com
drivers/gpu/drm/i915/gt/intel_hangcheck.c

index 6bcfa64..797d8ef 100644 (file)
@@ -57,9 +57,6 @@ static bool subunits_stuck(struct intel_engine_cs *engine)
        int slice;
        int subslice;
 
-       if (engine->id != RCS0)
-               return true;
-
        intel_engine_get_instdone(engine, &instdone);
 
        /* There might be unstable subunit states even when