btrfs: drop useless goto in open_fs_devices
authorAnand Jain <anand.jain@oracle.com>
Tue, 28 Apr 2020 15:22:25 +0000 (23:22 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 25 May 2020 09:25:27 +0000 (11:25 +0200)
There is no need of goto out in open_fs_devices() as there is nothing
special done there.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c

index aa1e0ae..bf953c4 100644 (file)
@@ -1185,7 +1185,6 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
 {
        struct btrfs_device *device;
        struct btrfs_device *latest_dev = NULL;
-       int ret = 0;
 
        flags |= FMODE_EXCL;
 
@@ -1198,16 +1197,15 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
                    device->generation > latest_dev->generation)
                        latest_dev = device;
        }
-       if (fs_devices->open_devices == 0) {
-               ret = -EINVAL;
-               goto out;
-       }
+       if (fs_devices->open_devices == 0)
+               return -EINVAL;
+
        fs_devices->opened = 1;
        fs_devices->latest_bdev = latest_dev->bdev;
        fs_devices->total_rw_bytes = 0;
        fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_REGULAR;
-out:
-       return ret;
+
+       return 0;
 }
 
 static int devid_cmp(void *priv, struct list_head *a, struct list_head *b)