qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 4 Apr 2021 12:42:44 +0000 (14:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Apr 2021 18:59:33 +0000 (11:59 -0700)
This ++ is confusing. It looks duplicated with the one already performed in
'skb_fill_page_desc()'.

In fact, it is harmless. 'nr_frags' is written twice with the same value.
Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1'
in 'skb_fill_page_desc()'.

So axe this post-increment to avoid confusion.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_fp.c

index 102d0e0..ee3e45e 100644 (file)
@@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev *edev,
                dma_unmap_page(rxq->dev, bd->mapping,
                               PAGE_SIZE, DMA_FROM_DEVICE);
 
-               skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+               skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
                                   bd->data, rxq->rx_headroom, cur_size);
 
                skb->truesize += PAGE_SIZE;