i2c: add param sanity check to i2c_transfer()
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 3 Apr 2018 19:11:50 +0000 (21:11 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 11 Apr 2018 21:33:46 +0000 (23:33 +0200)
The API docs describe i2c_transfer() as taking a pointer to an array
of i2c_msg containing at least 1 entry, but leaves it to the individual
drivers to sanity check the msgs and num parameters. Let's do this in
core code instead.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
[wsa: changed '<= 0' to '< 1']
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-core-base.c

index 1adeeba..1ba40bb 100644 (file)
@@ -1845,6 +1845,9 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
        unsigned long orig_jiffies;
        int ret, try;
 
+       if (WARN_ON(!msgs || num < 1))
+               return -EINVAL;
+
        if (adap->quirks && i2c_check_for_quirks(adap, msgs, num))
                return -EOPNOTSUPP;