ipv6: Remove flowi6_oif compare from __ip6_route_redirect
authorDavid Ahern <dsahern@gmail.com>
Fri, 12 Apr 2019 17:31:14 +0000 (10:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Apr 2019 00:05:38 +0000 (17:05 -0700)
In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"),
Martin noted that the flowi6_oif compare is moved to the new helper and
should be removed from __ip6_route_redirect. Fix the oversight.

Fixes: 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect")
Reported-by: Martin Lau <kafai@fb.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c

index d555eda..a77c004 100644 (file)
@@ -2471,8 +2471,6 @@ restart:
                        continue;
                if (rt->fib6_flags & RTF_REJECT)
                        break;
-               if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex)
-                       continue;
                if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6,
                                          &rdfl->gateway, &ret))
                        goto out;