iwlegacy: constify local structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 11 Sep 2016 13:05:50 +0000 (15:05 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 14 Sep 2016 17:01:40 +0000 (20:01 +0300)
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/intel/iwlegacy/3945.c

index 209dc99..4db327a 100644 (file)
@@ -2671,7 +2671,7 @@ const struct il_ops il3945_ops = {
        .send_led_cmd = il3945_send_led_cmd,
 };
 
-static struct il_cfg il3945_bg_cfg = {
+static const struct il_cfg il3945_bg_cfg = {
        .name = "3945BG",
        .fw_name_pre = IL3945_FW_PRE,
        .ucode_api_max = IL3945_UCODE_API_MAX,
@@ -2700,7 +2700,7 @@ static struct il_cfg il3945_bg_cfg = {
        },
 };
 
-static struct il_cfg il3945_abg_cfg = {
+static const struct il_cfg il3945_abg_cfg = {
        .name = "3945ABG",
        .fw_name_pre = IL3945_FW_PRE,
        .ucode_api_max = IL3945_UCODE_API_MAX,