intel-hid: Remove duplicated acpi_remove_notify_handler
authorAlex Hung <alex.hung@canonical.com>
Wed, 29 Jun 2016 03:41:15 +0000 (11:41 +0800)
committerDarren Hart <dvhart@linux.intel.com>
Wed, 29 Jun 2016 05:18:35 +0000 (22:18 -0700)
The second call to acpi_remove_notify_handler does not result in panic
or generate error messages, but it is unnecessary and the function
returns with an error. Remove the duplicate call. Correct two improperly
indented lines.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/intel-hid.c

index a818db6..ed58742 100644 (file)
@@ -122,8 +122,8 @@ static int intel_hid_input_setup(struct platform_device *device)
        return 0;
 
 err_free_device:
-               input_free_device(priv->input_dev);
-               return ret;
+       input_free_device(priv->input_dev);
+       return ret;
 }
 
 static void intel_hid_input_destroy(struct platform_device *device)
@@ -224,7 +224,6 @@ static int intel_hid_remove(struct platform_device *device)
        acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, notify_handler);
        intel_hid_input_destroy(device);
        intel_hid_set_enable(&device->dev, 0);
-       acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, notify_handler);
 
        /*
         * Even if we failed to shut off the event stream, we can still