powerpc/ftrace: Skip instruction patching if the instructions are the same
authorNaveen N Rao <naveen@kernel.org>
Wed, 30 Oct 2024 07:08:40 +0000 (12:38 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 31 Oct 2024 00:00:53 +0000 (11:00 +1100)
To simplify upcoming changes to ftrace, add a check to skip actual
instruction patching if the old and new instructions are the same. We
still validate that the instruction is what we expect, but don't
actually patch the same instruction again.

Signed-off-by: Naveen N Rao <naveen@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20241030070850.1361304-8-hbathini@linux.ibm.com
arch/powerpc/kernel/trace/ftrace.c

index fe0546f..7195172 100644 (file)
@@ -82,7 +82,7 @@ static inline int ftrace_modify_code(unsigned long ip, ppc_inst_t old, ppc_inst_
 {
        int ret = ftrace_validate_inst(ip, old);
 
-       if (!ret)
+       if (!ret && !ppc_inst_equal(old, new))
                ret = patch_instruction((u32 *)ip, new);
 
        return ret;