pid: use pid_has_task() in __change_pid()
authorChristian Brauner <christian.brauner@ubuntu.com>
Thu, 17 Oct 2019 10:18:30 +0000 (12:18 +0200)
committerChristian Brauner <christian.brauner@ubuntu.com>
Thu, 17 Oct 2019 13:36:56 +0000 (15:36 +0200)
Replace hlist_empty() with the new pid_has_task() helper which is more
idiomatic, easier to grep for, and unifies how callers perform this
check.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20191017101832.5985-3-christian.brauner@ubuntu.com
kernel/pid.c

index 0a9f2e4..124d40b 100644 (file)
@@ -299,7 +299,7 @@ static void __change_pid(struct task_struct *task, enum pid_type type,
        *pid_ptr = new;
 
        for (tmp = PIDTYPE_MAX; --tmp >= 0; )
-               if (!hlist_empty(&pid->tasks[tmp]))
+               if (pid_has_task(pid, tmp))
                        return;
 
        free_pid(pid);