leds: ktd2692: Avoid duplicate error messages on probe deferral
authorMarkuss Broks <markuss.broks@gmail.com>
Thu, 5 May 2022 15:25:16 +0000 (18:25 +0300)
committerPavel Machek <pavel@ucw.cz>
Sat, 7 May 2022 21:12:18 +0000 (23:12 +0200)
Use dev_err_probe instead of dev_err to avoid duplicate error
messages if the GPIO allocation makes the probe defer.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/flash/leds-ktd2692.c

index ed1f20a..8b99742 100644 (file)
@@ -279,17 +279,13 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
 
        led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS);
        ret = PTR_ERR_OR_ZERO(led->ctrl_gpio);
-       if (ret) {
-               dev_err(dev, "cannot get ctrl-gpios %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "cannot get ctrl-gpios\n");
 
        led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
        ret = PTR_ERR_OR_ZERO(led->aux_gpio);
-       if (ret) {
-               dev_err(dev, "cannot get aux-gpios %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, PTR_ERR(led->aux_gpio), "cannot get aux-gpios\n");
 
        led->regulator = devm_regulator_get(dev, "vin");
        if (IS_ERR(led->regulator))