net: dev_ioctl: remove redundant initialization of variable err
authorColin Ian King <colin.king@canonical.com>
Mon, 2 Nov 2020 12:16:15 +0000 (12:16 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Nov 2020 01:49:26 +0000 (17:49 -0800)
The variable err is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201102121615.695196-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev_ioctl.c

index 205e92e..db8a0ff 100644 (file)
@@ -230,7 +230,7 @@ static int dev_do_ioctl(struct net_device *dev,
                        struct ifreq *ifr, unsigned int cmd)
 {
        const struct net_device_ops *ops = dev->netdev_ops;
-       int err = -EOPNOTSUPP;
+       int err;
 
        err = dsa_ndo_do_ioctl(dev, ifr, cmd);
        if (err == 0 || err != -EOPNOTSUPP)