video: fbdev: kyro: remove set but not used 'ulBestVCO'
authorJason Yan <yanaijie@huawei.com>
Thu, 27 Aug 2020 13:00:08 +0000 (21:00 +0800)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 8 Sep 2020 11:33:28 +0000 (13:33 +0200)
This addresses the following gcc warning with "make W=1":

drivers/video/fbdev/kyro/STG4000InitDevice.c: In function
‘ProgramClock’:
drivers/video/fbdev/kyro/STG4000InitDevice.c:123:6: warning: variable
‘ulBestVCO’ set but not used [-Wunused-but-set-variable]
  123 |  u32 ulBestVCO = 0, ulBestClk = 0, ulBestScore = 0;
      |      ^~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
[b.zolnierkie: minor patch summary fixup]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200827130008.428706-1-yanaijie@huawei.com
drivers/video/fbdev/kyro/STG4000InitDevice.c

index 1d3f208..39438ba 100644 (file)
@@ -120,7 +120,7 @@ u32 ProgramClock(u32 refClock,
 {
        u32 R = 0, F = 0, OD = 0, ODIndex = 0;
        u32 ulBestR = 0, ulBestF = 0, ulBestOD = 0;
-       u32 ulBestVCO = 0, ulBestClk = 0, ulBestScore = 0;
+       u32 ulBestClk = 0, ulBestScore = 0;
        u32 ulScore, ulPhaseScore, ulVcoScore;
        u32 ulTmp = 0, ulVCO;
        u32 ulScaleClockReq, ulMinClock, ulMaxClock;
@@ -189,7 +189,6 @@ u32 ProgramClock(u32 refClock,
                                                ulScore = ulPhaseScore + ulVcoScore;
 
                                                if (!ulBestScore) {
-                                                       ulBestVCO = ulVCO;
                                                        ulBestOD = OD;
                                                        ulBestF = F;
                                                        ulBestR = R;
@@ -206,7 +205,6 @@ u32 ProgramClock(u32 refClock,
                           but we shall keep this code in case new restrictions come into play
                           --------------------------------------------------------------------------*/
                                                if ((ulScore >= ulBestScore) && (OD > 0)) {
-                                                       ulBestVCO = ulVCO;
                                                        ulBestOD = OD;
                                                        ulBestF = F;
                                                        ulBestR = R;