accel/ivpu: Remove invalid warnings
authorJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Mon, 30 Sep 2024 19:53:15 +0000 (21:53 +0200)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Fri, 11 Oct 2024 10:44:39 +0000 (12:44 +0200)
Warn in ivpu_file_priv_put() checks a pointer that is previously
accessed. Warn in ivpu_ipc_fini() can be triggered even in valid cases
where IPC is disabled upon closing the device.

Reviewed-by: Karol Wachowski <karol.wachowski@intel.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240930195322.461209-25-jacek.lawrynowicz@linux.intel.com
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
drivers/accel/ivpu/ivpu_drv.c
drivers/accel/ivpu/ivpu_ipc.c

index 14c2412..dc98314 100644 (file)
@@ -117,8 +117,6 @@ void ivpu_file_priv_put(struct ivpu_file_priv **link)
        struct ivpu_file_priv *file_priv = *link;
        struct ivpu_device *vdev = file_priv->vdev;
 
-       drm_WARN_ON(&vdev->drm, !file_priv);
-
        ivpu_dbg(vdev, KREF, "file_priv put: ctx %u refcount %u\n",
                 file_priv->ctx.id, kref_read(&file_priv->ref));
 
index a4ebb76..c8ae69a 100644 (file)
@@ -533,7 +533,6 @@ void ivpu_ipc_fini(struct ivpu_device *vdev)
 {
        struct ivpu_ipc_info *ipc = vdev->ipc;
 
-       drm_WARN_ON(&vdev->drm, ipc->on);
        drm_WARN_ON(&vdev->drm, !list_empty(&ipc->cons_list));
        drm_WARN_ON(&vdev->drm, !list_empty(&ipc->cb_msg_list));
        drm_WARN_ON(&vdev->drm, atomic_read(&ipc->rx_msg_count) > 0);